Skip to content

feat(web): arrange panels in a draggable dock - #29069

Closed
faetalize wants to merge 7 commits into
pingdotgg:mainfrom
faetalize:feature/modular-panel-system
Closed

faetalize wants to merge 7 commits into
pingdotgg:mainfrom
faetalize:feature/modular-panel-system

docs: remove the dock internals and panels guide

55dd819
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Nov 2, 2026 in 2m 44s

Needs Human Approval

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This changes the default workspace to a draggable dock and adds static-analysis suppressions, both requiring human review. The replacement installation instructions also direct users to a mutable fork-based patcher that replaces the installed application archive.

Additional Thinking

Your Custom Policy

The default criteria apply. The explicit product-default restriction is triggered by replacing the existing terminal drawer and fixed panel presentation with the dock and changing file-explorer behavior. The static-analysis restriction is independently triggered by newly added oxlint-disable-next-line directives in files including ChatDockSurfaces.tsx, DockHostPortal.tsx, and DockWorkspace.tsx. Both requirements mandate human review.

Code

Replaces the fixed panel and terminal drawer with a persisted draggable dock, changes file-explorer presentation and terminal shortcuts, and adds sidebar positioning and layout reset controls. Also replaces installation documentation with a fork-hosted script that downloads a mutable patch, rebuilds the client, and replaces the installed application archive using sudo. Dock reset and stable portal hosts limit layout disruption but do not address installer trust.

Review Context

Author supplied as faetalize; ownership and check results were not supplied. Ten unresolved Macroscope findings describe incorrect drop placement, terminal targeting, focus, visibility, and pending-group routing. All are Medium or High and meet the separately enforced SEVERITY_MEDIUM blocking threshold; they are not re-adjudicated here.

Verdict

Human review is required by both explicit customer restrictions. A human must accept the changed default workspace behavior and added lint suppressions. Separately, the new recommended installer introduces a mutable fork-controlled source into an installed application; a human must determine whether that distribution and trust model is appropriate before directing users to execute it.

Notes:
No code owners found in target merge base fa31b66

Correctness
10 blocking correctness issues found


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.