fix(clients): cancel oversized project icon responses

packages/client-runtime/src/projectFaviconCache.test.ts

@@ -202,11 +202,19 @@ describe("project favicon image loader", () => {
     await expect(load(url, signal())).rejects.toThrow("too large");
     expect(pulled).toBeLessThan(PROJECT_FAVICON_MAX_SOURCE_BYTES / chunk.byteLength + 3);
     expect(downscale).not.toHaveBeenCalled();
+    let cancelled = false;
+    const declaredStream = new ReadableStream<Uint8Array>({
+      cancel() {
+        cancelled = true;
+      },
+    });
     const declared = loader(
-      new Response("x", {
+      new Response(declaredStream, {
         headers: { "content-type": "image/png", "content-length": String(2 ** 40) },
       }),
     );
     await expect(declared.load(url, signal())).rejects.toThrow("too large");
+    expect(cancelled).toBe(true);
+    expect(declared.downscale).not.toHaveBeenCalled();
   });
 });

packages/client-runtime/src/projectFaviconCache.ts

@@ -50,7 +50,10 @@ export interface ProjectFaviconStorage {
 
 async function readBounded(response: Response, maxBytes: number) {
   const declared = Number(response.headers.get("content-length"));
-  if (declared > maxBytes) throw new Error("Project icon is too large to decode.");
+  if (declared > maxBytes) {
+    await response.body?.cancel().catch(() => {});
+    throw new Error("Project icon is too large to decode.");
+  }
   if (!response.body) {
     const bytes = new Uint8Array<ArrayBuffer>(await response.arrayBuffer());
     if (bytes.byteLength > maxBytes) throw new Error("Project icon is too large to decode.");