Repository navigation
Conversation
PR Size triggers only on pull_request_target, and sync-label-definitions runs only when the event is not pull_request_target, so every run skips it. The repo's size:* labels still carry the descriptions from before pingdotgg#1105, which shows the job has never synced. Remove it and the label colors and descriptions that only it read. Same removal as pingdotgg#4135 by kridaydave. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Removes a label-sync job that cannot run under the workflow’s only trigger, along with unused label metadata. Existing PR sizing and label assignment remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Managed label configuration .github/workflows/pr-size.yml |
The label entries now contain only their names. The job that created or updated label definitions was removed. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Refactor
Possibly related PRs
- pingdotgg/t3code#28650: Both PRs change
.github/workflows/pr-size.ymland thesync-label-definitionsjob.
Suggested reviewers: macroscopeapp
Merge Risk: 
Minimal · up to 5058e
-
The workflow retains its existing label behavior. No merge-blocking risk was identified.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The pull request description follows the required template. It explains the problem, change, scope and approval basis, verification steps, observed results, and the live-run limitation. It also identifies generated-agent usage.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Problem
PR Size only triggers on
pull_request_target, but itssync-label-definitionsjob only runs when the event is notpull_request_target. So every run skips it, as in run 41325286591. It has never run since theworkflow_dispatchandpushtriggers were removed in 581d242. The repo'ssize:*labels still have their old descriptions, such as "0-9 changed lines (additions + deletions).", not the "test files excluded in mixed PRs" text #1105 added to this job.Change
sync-label-definitionsjob.coloranddescriptionfrom the label list inprepare-config. Only the deleted job read them; thelabeljob only readsname.The trigger and the whole
labeljob are unchanged.prepare-configstill emitslabels_json, with the same label names. Labels already on GitHub keep their current colors and descriptions.Scope and approval
This removes a job that cannot run, with no behavior change, so it should qualify as a small, focused fix without a prior issue. Restoring a trigger so the job runs again would be a different change. I left it out because the triggers were removed on purpose.
Verification
vp run check:changed 1d626d02d95f9a2343553f6498037ee82290d304: passes.actionlint .github/workflows/pr-size.yml: no findings.prepare-configandlabel, andlabel.needsisprepare-config.label:to the end of the file is byte-identical, and so is the trigger.sync-label-definitions.Not checked: a live PR Size run on this change.
pull_request_targetruns the workflow from the base branch, so this PR's own size label still comes from the current file.Prior PRs
timeout-minutesto the jobs in this file, including the one deleted here. Whichever lands second needs a one-line conflict fix.Generated with Claude Opus 5.5 and GPT-6.1 Terra and GPT-6.1 Sol in T3 Code Nightly