Skip to content

ci: drop the PR size label sync job that can never run - #28735

Open
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m117
Open

only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m117

Conversation

@only21mil

@only21mil only21mil commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem

PR Size only triggers on pull_request_target, but its sync-label-definitions job only runs when the event is not pull_request_target. So every run skips it, as in run 41325286591. It has never run since the workflow_dispatch and push triggers were removed in 581d242. The repo's size:* labels still have their old descriptions, such as "0-9 changed lines (additions + deletions).", not the "test files excluded in mixed PRs" text #1105 added to this job.

Change

  • Delete the sync-label-definitions job.
  • Drop color and description from the label list in prepare-config. Only the deleted job read them; the label job only reads name.

The trigger and the whole label job are unchanged. prepare-config still emits labels_json, with the same label names. Labels already on GitHub keep their current colors and descriptions.

Scope and approval

This removes a job that cannot run, with no behavior change, so it should qualify as a small, focused fix without a prior issue. Restoring a trigger so the job runs again would be a different change. I left it out because the triggers were removed on purpose.

Verification

  • Ran vp run check:changed 1d626d02d95f9a2343553f6498037ee82290d304: passes.
  • Ran actionlint .github/workflows/pr-size.yml: no findings.
  • Parsed the workflow: the jobs are prepare-config and label, and label.needs is prepare-config.
  • Compared with main: everything from label: to the end of the file is byte-identical, and so is the trigger.
  • Checked that nothing else in the repo names sync-label-definitions.

Not checked: a live PR Size run on this change. pull_request_target runs the workflow from the base branch, so this PR's own size label still comes from the current file.

Prior PRs

Generated with Claude Opus 5.5 and GPT-6.1 Terra and GPT-6.1 Sol in T3 Code Nightly

PR Size triggers only on pull_request_target, and sync-label-definitions
runs only when the event is not pull_request_target, so every run skips
it. The repo's size:* labels still carry the descriptions from before
pingdotgg#1105, which shows the job has never synced. Remove it and the label
colors and descriptions that only it read.

Same removal as pingdotgg#4135 by kridaydave.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5058ec8

Macroscope's review found this PR approvable — Removes a label-sync job that cannot run under the workflow’s only trigger, along with unused label metadata. Existing PR sizing and label assignment remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 3fd2b85 and 5058ec8.

Files selected for processing: 1
  • .github/workflows/pr-size.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The PR size workflow now defines only the six managed label names. It no longer creates missing labels or updates existing label colors and descriptions.

Changes: PR size label configuration

Layer / File(s) Summary
Managed label configuration
.github/workflows/pr-size.yml
The label entries now contain only their names. The job that created or updated label definitions was removed.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Possibly related PRs

Suggested reviewers: macroscopeapp

Merge Risk: Minimal · up to 5058e

The workflow retains its existing label behavior. No merge-blocking risk was identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: removing the PR size label sync job because it cannot run.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description follows the required template. It explains the problem, change, scope and approval basis, verification steps, observed results, and the live-run limitation. It also identi…
Full details: Description check

Explanation

The pull request description follows the required template. It explains the problem, change, scope and approval basis, verification steps, observed results, and the live-run limitation. It also identifies generated-agent usage.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant