Skip to content

fix(desktop): one unreadable value in desktop-settings.json no longer resets every desktop setting - #28682

Open
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m060
Open

only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m060

fix(desktop): one unreadable value in desktop-settings.json no longer…

a3ca0bd
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 1, 2026 in 2m 12s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Unreadable desktop settings now fall back individually, preserving other saved preferences. Existing defaults and validation remain unchanged, with no new operational behavior introduced.

Additional Thinking

Your Custom Policy

Applied default approvability criteria. The change preserves existing saved preferences without changing product defaults, and adds no static-analysis suppression directives; neither additional human-review requirement is triggered.

Code

Desktop settings decoding now discards individual unreadable fields while retaining readable saved preferences, rather than resetting the entire document. Existing defaults, normalization, JSON parsing fallback, and write operations remain unchanged. Investigation covered the settings schemas and read/write paths; the customer-ignored file was not reconstructed.

Review Context

Author supplied as only21mil; no ownership requirements were supplied or found. The supplied review-thread check reports no unresolved comments. No correctness findings, blocking-severity configuration, or CI results were supplied.

Verdict

The change is confined to recovery from individually unreadable saved settings. Readable preferences remain explicitly saved user choices, including network settings; missing or unreadable fields retain existing normalization and defaults. No new permissions, defaults, or operational actions are introduced, and no obvious material risk requires human judgment.

Notes:
No code owners found in target merge base 8760d06


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.