Skip to content

perf(codex): trace app server request latency - #28666

Merged
Yash-Singh1 merged 1 commit into
mainfrom
t3/attribute-codex-discovery-latency
Nov 1, 2026
Merged

Yash-Singh1 merged 1 commit into
mainfrom
t3/attribute-codex-discovery-latency

perf(codex): trace app server request latency

95d983f
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 1, 2026 in 1m 32s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Adds request-latency tracing and guaranteed pending-request cleanup for Codex app-server calls. The assessed change preserves wire messages and records protocol metadata, not request payloads.

Additional Thinking

Your Custom Policy

The assessed change neither changes product defaults nor adds or broadens static-analysis suppression directives, so neither additional human-review requirement applies. The omitted file remains outside the assessment under the supplied ignore rules.

Code

The assessed protocol change annotates request spans with JSON-RPC method and numeric request ID, adds enqueue and response-wait timing spans, and brackets pending-request registration with guaranteed cleanup. It reaches outgoing Codex requests but does not add payload contents to telemetry or alter wire messages. The customer-ignored file was not reconstructed.

Review Context

The author has write access and ping-devs membership; no ownership requirement was supplied. The supplied review-thread check reports no unresolved comments or correctness findings. No check results or blocking-severity configuration were supplied.

Verdict

The understood change is limited to request observability and in-memory lifecycle cleanup. Trace attributes contain protocol metadata rather than request payloads, and existing transport and response routing remain unchanged. No obvious material exposure or product decision requires human judgment.

Notes:
No code owners found in target merge base b50d8a1


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.