Repository navigation
fix(server): interrupted scheduled task runs no longer stay busy - #28474
Approved
- Eligibility
- Correctness
Note
More information about how approvability works can be found in our Help Center.
Details
Eligibility
The change makes scheduled-run and webhook-worker busy reservations interruption-safe. Existing execution safeguards and queue processing remain intact, with no product-default changes or new data-handling behavior.
Additional Thinking
Your Custom Policy
Default approvability criteria apply. The assessed change neither changes product defaults nor adds or broadens static-analysis suppression directives, so neither additional human-review requirement is triggered.
Code
Wraps scheduled-run and pending-webhook in-memory reservations in acquire/use/release brackets so interruption releases busy markers. Pending workers acquire their own reservations within the service-scoped fiber; per-task permits, persisted queue handling, and existing run-error cleanup remain in place. Assessment respects the two ignored files without reconstructing them.
Review Context
Author is a repository admin and ping-devs member; no specific ownership requirement was supplied. There are no supplied unresolved review comments or correctness findings. Check results and blocking-severity configuration were not supplied.
Verdict
This is a bounded lifecycle cleanup correction to existing task execution. It preserves task eligibility, delivery processing, and per-task serialization while preventing stale in-memory reservations after interruption. No material product-policy change or new persistent-data operation requires human judgment.
Notes:
No code owners found in target merge base 6328c84
Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.