Skip to content

fix(server): a stored boolean settledOverride no longer stops startup - #28314

Merged
juliusmarminge merged 2 commits into
mainfrom
fix/issue-28279
Nov 2, 2026
Merged

juliusmarminge merged 2 commits into
mainfrom
fix/issue-28279

fix(server): repair stored boolean settledOverride so startup recover…

71e4bbc
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Oct 31, 2026 in 1m 30s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This migration repairs invalid boolean thread-settlement values that prevent server startup, leaving valid values and other fields unchanged. The narrowly scoped repair is supported by reported migration tests and a successful before/after startup reproduction.

Additional Thinking

Your Custom Policy

Default criteria apply. This repairs invalid persisted representations without changing product defaults, and adds no static-analysis suppression directives, so neither mandatory-human-review condition applies.

Code

Registers migration 077 to repair only boolean settledOverride values in valid thread-projection JSON: true becomes "settled", false becomes null. Other fields and already-valid values are unchanged; the strict schema remains intact. Ignored files were not reconstructed.

Review Context

The author is a repository admin and ping-devs member; no ownership requirement was supplied. No unresolved comments, correctness findings, or blocking-severity configuration were supplied. The PR description reports head-revision migration tests and a before/after server-startup reproduction demonstrating recovery; desktop execution was not checked. No CI check-state results were supplied.

Verdict

The persistent update is narrowly confined to invalid boolean representations of a single projection field. Reported runtime reproduction and preservation tests support the intended startup repair, with no broad data deletion, exposure, or unresolved product decision requiring human judgment.

Notes:
No code owners found in target merge base 15fe283


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.