Skip to content

fix(server): stop event subscribers before closing the database - #27831

Merged
maria-rcks merged 1 commit into
mainfrom
fix/project-settings-upgrade-flake
Oct 30, 2026
Merged

maria-rcks merged 1 commit into
mainfrom
fix/project-settings-upgrade-flake

fix(server): stop event subscribers before closing the database

f6e1229
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Oct 30, 2026 in 2m 49s

Approved

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
The two event subscribers now stop with the orchestrator instead of remaining detached during shutdown. Event processing logic is unchanged, and the change is limited to service lifecycle cleanup.

Additional Thinking

Your Custom Policy

Default approvability criteria apply. Neither product defaults nor static-analysis suppression directives change, so neither additional human-review requirement is triggered.

Code

Changes two orchestration event subscribers from detached fibers to scope-owned fibers. They continue processing run and child-work events while the orchestrator is active, but are interrupted when its layer closes. The runtime layer supplies their event sink and stores as dependencies; event filters, handlers, and persistence logic are unchanged.

Review Context

The author has repository write access; no specific ownership information was supplied. No unresolved review comments or correctness findings were supplied, and no check results were provided. The supplied diff was confirmed against the requested commits.

Verdict

This is a bounded lifecycle correction tying existing subscribers to their owning service scope rather than allowing them to outlive its dependencies. It does not change active-service processing policy, data schemas, permissions, or product defaults. No obvious material risk requiring human judgment remains.

Notes:
No code owners found in target merge base 4fb9e5d


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.