Skip to content

perf(client): skip idle inbox placement serialization #27460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 4 commits into from
Nov 3, 2026
+15 −12
Merged

perf(client): skip idle inbox placement serialization #27460

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5eb0c6
perf(client): skip idle inbox placement serialization
UtkarshUsername Oct 30, 2026
a2e4648
Merge remote-tracking branch 'github/main' into takeover-27460
maria-rcks Nov 2, 2026
28eb763
Merge remote-tracking branch 'github/main' into takeover-27460-fixup
maria-rcks Nov 2, 2026
4dc8cef
test(client): keep inbox return assertions behavioral
maria-rcks Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/client-runtime/src/state/threadInbox.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ describe("createInboxReturnTracker", () => {
});
it("stamps a thread when it stops working, but never on the first observation", () => {
const tracker = createInboxReturnTracker();
using stringify = vi.spyOn(JSON, "stringify");
const first = tracker.observe([thread("a", true), thread("b", false)]);
expect(stringify).toHaveBeenCalledTimes(1);
expect(first.returnedAt(thread("a", true))).toBeUndefined();
expect(first.returnedAt(thread("b", false))).toBeUndefined();

Expand Down
27 changes: 15 additions & 12 deletions packages/client-runtime/src/state/threadInbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export function createInboxReturnTracker() {
const keyOf = (thread: ThreadKeyInput) => `${thread.environmentId}:${thread.id}`;
const states = new Map<
string,
{ working: boolean; deadline: number | null; placement: string }
{ working: boolean; deadline: number | null; placement: string | null }
>();
const returns = new Map<string, number>();
const listeners = new Set<() => void>();
Expand Down Expand Up @@ -184,17 +184,21 @@ export function createInboxReturnTracker() {
for (const thread of threads) {
const key = keyOf(thread);
present.add(key);
const placement = JSON.stringify([
thread.archivedAt,
thread.deletedAt,
thread.pinnedAt,
thread.settledOverride,
thread.settledAt,
thread.snoozedAt,
thread.snoozedUntil,
thread.activeOrderKey,
]);
const previous = states.get(key);
const actual = isThreadWorking(thread);
const placement =
actual || previous?.working
? JSON.stringify([
thread.archivedAt,
thread.deletedAt,
thread.pinnedAt,
thread.settledOverride,
thread.settledAt,
thread.snoozedAt,
thread.snoozedUntil,
thread.activeOrderKey,
])
: null;
const actionable =
thread.hasPendingApprovals ||
thread.hasPendingUserInput ||
Expand All @@ -210,7 +214,6 @@ export function createInboxReturnTracker() {
thread.pinnedAt != null ||
thread.settledOverride === "settled" ||
effectiveSnoozed(thread, { now: observedAt });
const actual = isThreadWorking(thread);
// Only shelf placement is held: execution state and attention requests stay authoritative.
const deadline =
!actual && previous?.working && !actionable && !moved && !excluded
Expand Down
Loading