Skip to content

fix(cli): trace summary no longer prints near-second durations as "1000ms" #27266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 4 commits into from
Nov 1, 2026
+13 −3
Merged

fix(cli): trace summary no longer prints near-second durations as "1000ms" #27266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa40708
fix(cli): trace summary no longer prints near-second durations as "10…
MarcoDotIO Oct 29, 2026
3db0da1
Merge upstream main into fix/trace-summary-1000ms
MarcoDotIO Oct 30, 2026
a0fa063
chore: merge current main into trace duration fix
maria-rcks Oct 31, 2026
a4f1bde
refactor(cli): remove redundant duration rounding comment
maria-rcks Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/server/src/cli/trace.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { assert, it } from "@effect/vitest";

import { makeTraceSpanSummary } from "./trace.ts";
import { formatTraceSummary, makeTraceSpanSummary } from "./trace.ts";

const MINUTE_MS = 60_000;

Expand Down Expand Up @@ -62,3 +62,13 @@ it("reads failures and interrupts of browser spans from their OTLP status", () =
const [render] = summarizer.finish().spans;
assert.deepStrictEqual([render?.count, render?.interrupted, render?.failures], [4, 2, 1]);
});

it("prints durations that round up to a second in seconds", () => {
const summarizer = makeTraceSpanSummary();
[span("rpc", 999.4, MINUTE_MS), span("rpc", 999.6, 2 * MINUTE_MS)].forEach(summarizer.addLine);

const row = formatTraceSummary(summarizer.finish(), 25)
.split("\n")
.find((line) => line.startsWith("rpc"));
assert.deepStrictEqual(row?.trim().split(/\s+/).slice(3, 6), ["999ms", "1s", "1s"]);
});
4 changes: 2 additions & 2 deletions apps/server/src/cli/trace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ export function makeTraceSpanSummary(sinceMs = -Infinity) {
}

const formatMs = (ms: number) =>
ms < 1_000 ? `${Math.round(ms)}ms` : `${Math.round(ms / 100) / 10}s`;
Math.round(ms) < 1_000 ? `${Math.round(ms)}ms` : `${Math.round(ms / 100) / 10}s`;

function formatTraceSummary(
export function formatTraceSummary(
summary: ReturnType<ReturnType<typeof makeTraceSpanSummary>["finish"]>,
limit: number,
) {
Expand Down
Loading