Repository navigation
fix(client-runtime): honor shared names for grouped repos - #27133
iTzFrancesco wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Grouped repositories now retain their shared saved name instead of substituting a repository identity label. The change affects display text only; grouping identities and stored data remain unchanged. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Select and verify the shared project title packages/client-runtime/src/state/projectGrouping.ts, packages/client-runtime/src/state/projectGrouping.test.ts |
The label derivation now returns the sole shared project title when it matches the repository name. The test checks the group key, members, and label for matching projects across environments. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related issues
pingdotgg/t3code#26296: Both concern a shared title that matches the repository name. This change does not add the issue’s provider-identity rule for other repositories.pingdotgg/t3code#24999: The shared title may align the grouped label with the selected checkout title. This change does not address cases where member titles differ.pingdotgg/t3code#15049: This change accepts a saved title that matches the repository name. It does not establish whether rename persistence succeeds.
Suggested labels: bugfix, size:S
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to f73df
-
The intended project-label mismatch is addressed without changing grouping identity or selection behavior; no merge-blocking risk was established.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description covers the required Problem, Change, Scope and approval, and Verification sections. It explains the behavior, implementation, regression test, validation results, failed broader check, missing UI evidence, and trade-off.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
closing at @StiensWout's request under Provide evidence for the changed behavior. Changes project-picker and settings group labels from owner/repo to a unanimous saved short project name across environments. The author explicitly reports no real-client before/after screenshot or integrated UI pass. submission evidence: "No real-client before/after screenshot or integrated UI pass was captured." Attach before/after screenshots of the grouped project label in the picker and settings. thanks for trying to help improve t3 code. if you think this closure was a mistake, please open a fresh pr addressing the requirement above, and link back to this one. |
Problem
With repository grouping enabled, a group whose checkouts share a title identical to the repository name is shown as owner/repo. Adding the same repository on another environment can therefore change the project picker and settings label even though the saved project name is still the short name. This is the short-name case reported in #4880.
Change
Prefer a unanimous non-empty saved title when deriving a group label, including when it matches the repository name. Fall back to repository identity only when member titles disagree or are absent. Repository grouping keys and remote identity are unchanged.
Scope and approval
This is a focused fix for the mismatch between the saved Project name and the derived group label. It changes display text only and does not change repository grouping or identity. Related to #4880.
Verification
GPT-6 Luna via T3 Code (Codex harness).