Skip to content

test(web): attachment font and large-text preview tests wait for the real load - #26314

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/attachment-preview-flakes
Oct 28, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3code/attachment-preview-flakes

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

Two AttachmentFilePreview browser tests still failed on main after https://git.cafe/pingdotgg/t3code/pulls/25664 (4 main reds since 2026-10-26 16:29).

  • retains the workspace viewer across URL renewals…: CI showed 64 lines · Indexing…, because the cold large-text worker had not posted its final meta count within vi.waitFor's 1s. The test's Worker stub now resolves a promise on that {type:"meta", complete:true} message, and the test awaits it before asserting 1,000 lines.
  • loads a font attachment through the lazy preview: two chained lazy chunks (FontFilePreview → FontViewer) loaded cold inside one 1s wait. The test preloads both chunks, the same way the file already handles ReadOnlySourcePreview. The lazy render path is unchanged.

No timeouts, retries, or skips were added. Both tests passed repeated local runs, including with every core busy, and vp run check:changed passes. Neither failure reproduced locally on the original code either, so the causes come from the CI failure output.

Implemented with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

…real load

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8f805f7

Macroscope's review found this PR approvable — The change is confined entirely to ignored paths and is described as improving test waits for preview loading. The supplied scope and review context identify no material risk requiring human judgment.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 49582b7 into main Oct 28, 2026
28 of 29 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/attachment-preview-flakes branch October 28, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant