Repository navigation
test(web): attachment font and large-text preview tests wait for the real load - #26314
Merged
Merged
Conversation
…real load Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The change is confined entirely to ignored paths and is described as improving test waits for preview loading. The supplied scope and review context identify no material risk requiring human judgment. Notes:
You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
AttachmentFilePreviewbrowser tests still failed on main after https://git.cafe/pingdotgg/t3code/pulls/25664 (4 main reds since 2026-10-26 16:29).64 lines · Indexing…, because the cold large-text worker had not posted its finalmetacount withinvi.waitFor's 1s. The test'sWorkerstub now resolves a promise on that{type:"meta", complete:true}message, and the test awaits it before asserting1,000 lines.FontFilePreview→FontViewer) loaded cold inside one 1s wait. The test preloads both chunks, the same way the file already handlesReadOnlySourcePreview. The lazy render path is unchanged.No timeouts, retries, or skips were added. Both tests passed repeated local runs, including with every core busy, and
vp run check:changedpasses. Neither failure reproduced locally on the original code either, so the causes come from the CI failure output.Implemented with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code