Skip to content

fix(web): usage limit banner no longer flickers between one and two rows #26071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatthewFeroz wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

fix(web): usage limit banner no longer flickers between one and two rows #26071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/web/src/components/chat/ComposerBannerStack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,20 @@ export function ComposerBannerStack({
));
}

/**
* Text that grows an info button when it truncates. `slotClassName` styles the span holding both;
* give it a width that ignores its content when the button would otherwise reflow the row.
*/
export function NoticeText({
children,
className,
detailsLabel,
slotClassName = "contents",
}: {
readonly children: ReactNode;
readonly className: string;
readonly detailsLabel: string;
readonly slotClassName?: string;
}) {
const textRef = useRef<HTMLSpanElement>(null);
const detailsRef = useRef<HTMLButtonElement>(null);
Expand Down Expand Up @@ -88,7 +94,7 @@ export function NoticeText({
}, []);

return (
<span className="contents">
<span className={slotClassName}>
<span ref={textRef} className={className}>
{children}
</span>
Expand Down Expand Up @@ -154,7 +160,10 @@ function NoticeCard({ item }: { readonly item: ComposerBannerStackItem }) {
? `Show details: ${item.title}`
: "Show notice details"
}
className="w-0 min-w-0 grow truncate text-muted-foreground @max-[400px]:sr-only"
// A fixed-minimum slot keeps the info button out of the row's wrap decision;
// otherwise showing it wraps the actions, the text fits, and it hides again.
slotClassName="flex w-0 min-w-7 grow items-center gap-1 sm:min-w-6"
className="min-w-0 truncate text-muted-foreground @max-[400px]:sr-only"
>
{item.description}
</NoticeText>
Expand Down
Loading