Skip to content

fix(mobile): switching pull request tabs no longer jumps the page #26064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Oct 27, 2026
Merged

fix(mobile): switching pull request tabs no longer jumps the page #26064

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e952c
fix(mobile): switching pull request tabs no longer jumps the page
flamboh Oct 27, 2026
6efe201
fix(mobile): Android PR tabs use their own top edge, not the status b…
flamboh Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
requestedSection.current = next;
scrollOffsets.current[next] = offset;
currentScrollOffset.current = { tab: next, offset };
scrollViews.current[next]?.scrollToOffset({ offset, animated: false });
// LegendList clamps to its measured rows, which leave out the short-tab minHeight below.
scrollViews.current[next]?.getNativeScrollRef().scrollTo({ y: offset, animated: false });
setSection(next);
};
const tabContent = activityContent;
Expand Down Expand Up @@ -676,6 +677,8 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
// move the list in the same frame as the bar.
contentInsetAdjustmentBehavior="automatic"
contentInsetStartAdjustment={Platform.OS === "ios" ? insets.top : 0}
// RN scrollTo clamps against raw insets and ignores the automatic bar inset.
scrollToOverflowEnabled
refreshControl={
<RefreshControl
refreshing={section === tab && pullRefresh.refreshing}
Expand Down
Loading