Skip to content

fix(mobile): PR tab switches no longer leave Liquid Glass behind #26041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 3 commits into from
Oct 31, 2026
+19 −13
Merged

fix(mobile): PR tab switches no longer leave Liquid Glass behind #26041

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaf6ecc
fix(mobile): PR tab switches no longer leave Liquid Glass behind
camchis Oct 27, 2026
6a880c8
chore(mobile): merge main into pr tab glass fix
maria-rcks Oct 30, 2026
1db6372
fix(mobile): preserve pr header sizing across tabs
maria-rcks Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,19 +873,25 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
}}
>
<PullRequestIdentity pr={identity} params={params} />
<SegmentedControl
options={[
{ value: "overview", label: "Overview" },
...(guidesEnabled
? [{ value: "guide" as const, label: "Guide" }]
: []),
{ value: "activity", label: "Activity" },
]}
selected={section}
onSelect={selectSection}
role="tab"
size="compact"
/>
{/* UIKit draws the tapped control's glass lens outside the hidden
tab's opacity, so only the visible tab mounts the control. */}
{Platform.OS !== "ios" || section === tab ? (
<SegmentedControl
options={[
{ value: "overview", label: "Overview" },
...(guidesEnabled
? [{ value: "guide" as const, label: "Guide" }]
: []),
{ value: "activity", label: "Activity" },
]}
selected={section}
onSelect={selectSection}
role="tab"
size="compact"
/>
) : (
<View style={{ height: 32 }} />
)}
</View>
) : null}
</>
Expand Down
Loading