Skip to content

fix(web): allow goal resume during an active turn - #26022

Open
diddletime wants to merge 1 commit into
pingdotgg:mainfrom
diddletime:fix/goal-resume-while-working
Open

diddletime wants to merge 1 commit into
pingdotgg:mainfrom
diddletime:fix/goal-resume-while-working

Conversation

@diddletime

Copy link
Copy Markdown

A paused goal hides Resume while another turn is running, forcing a separate Stop action. Show Resume whenever the goal supports it so the existing server command can stop the current turn and resume the goal.

Addresses #25951. The server transition shipped in #25426; this fixes the remaining button restriction. The intermittent native resume failure in the report still needs a specific reproduction.

Verified with vp run check:changed and a browser regression that renders a paused goal while another turn is working. The images show that component fixture.

Before After
Resume is missing Resume is available

Created with gpt-6-astra-ultrafast in Codex through T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 27, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at e901841

Macroscope's review found this PR approvable — This is a narrowly scoped web bug fix that exposes the existing Resume action for paused goals during an active turn, matching the already-supported server behavior. A focused browser regression test covers the changed state, with no schema, configuration, security, billing, or deployment impact.

Notes:

  • Code review disabled. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between dc84b09 and e901841.

Files selected for processing: 2
  • apps/web/src/components/chat/ComposerBannerStack.browser.test.tsx
  • apps/web/src/components/chat/ThreadActivityBanners.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The goal banner now shows Resume when presentation.canResume is true, including while the thread is working. A browser test covers the paused-goal, working-thread state.

Changes: Goal Resume Availability

Layer / File(s) Summary
Resume action and browser coverage
apps/web/src/components/chat/ThreadActivityBanners.tsx, apps/web/src/components/chat/ComposerBannerStack.browser.test.tsx
goalNowItem no longer requires the thread to be idle to show Resume. A browser test checks that Resume is visible while a paused goal's thread is working.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to e9018

The Resume behavior is covered by the browser regression, with no unresolved merge-blocking risk identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Description check Passed The description explains the problem, change, scope, and verification. It references issue #25951, describes the browser regression, includes before-and-after UI evidence, and identifies the agent and…
Title check Passed The title clearly and concisely describes the main change: allowing goal resume during an active turn.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, change, scope, and verification. It references issue #25951, describes the browser regression, includes before-and-after UI evidence, and identifies the agent and harness used.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant