Repository navigation
Conversation
@cursor/sdk 1.0.38 moved zod to peerDependencies. The desktop stage only installs runtime externals that apps/server lists, so app.asar shipped without zod and the backend crashed on start with "Cannot find module 'zod/v4'". List zod in apps/server so it is staged. Fixes #25840 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a minimal dependency-manifest and lockfile fix for packaged desktop startup, confined to ignored metadata paths. It introduces no new capability, product-default change, schema change, or static-analysis suppression. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Declare zod dependency apps/server/package.json |
The server package adds zod version ^4.6.5 to its dependencies. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix · Severity of issue fixed: Medium
Possibly related issues
- pingdotgg/t3code#25840 — The issue describes the missing
zoddependency that this change adds to the server package.
Possibly related PRs
- pingdotgg/t3code#25841 — Adds a regression test for staging required peer dependencies, including
@cursor/sdk'szoddependency.
Suggested reviewers: gcrft123, juliusmarminge
Merge Risk: 
Minimal · up to b7ac3
-
This dependency change is ready to merge; no current merge-blocking risk is evident.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description explains the macOS startup failure, identifies the missing runtime dependency, describes the fix, references issue
#25840, and states the scope. It does not report verification steps or observed results.
Full details: Linked Issues check
-
Explanation
The only directly linked issue,
#25840, is closed. Under the assessment rules, it supplies background only. No active directly linked targets remain, so no linked-issue coding requirements apply. The issue text describes the root cause and a workaround (add "zod": "^4.6.5" to apps/server dependencies). This PR applies that workaround, but the verdict does not depend on it.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR change set, per the raw summary, is one dependency addition in apps/server/package.json (+2/-1): "zod" at "^4.6.5". The current PR description states this change is the entire fix. It makes zod a listed dependency of apps/server. The desktop staging step then includes zod, because zod is already in the runtime external list. This ties the change directly to the stated purpose. The lockfile is an ignored file and was not inspected. Its absence does not affect this verdict. No unrelated changes are reported.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Superseded by #25841, which landed the same fix plus a regression test. |
Nightly
0.1.4-nightly.20261027.3766does not open on macOS. The backend crashes on every start withCannot find module 'zod/v4', required fromapp.asar/node_modules/@cursor/sdk. Reported in #25840.@cursor/sdk1.0.38 movedzodtopeerDependencies. The desktop stage only installs runtime externals thatapps/server/package.jsonlists, andapps/serverdid not listzod. Soapp.asarshipped without it.Fix: add
zod(^4.6.5, the version already in the lockfile) toapps/serverdependencies.zodis already in the runtime external list, so it is now staged next to@cursor/sdk.Same fix as #25841 by @jason5545, which also adds a regression test. This PR is only the dependency change, from a branch in this repo so CI runs now.
Fixes #25840
Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code