Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Branchless sidebar cards retain the standard height and bottom metadata line, while compact rows keep their existing layout. The change is presentation-only with limited, reversible impact. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Row height and metadata placement apps/web/src/components/sidebar/SidebarThreadRow.tsx |
The empty-metadata condition now applies only to non-card variants. Card rows retain a fixed intrinsic-size estimate and content height. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related PRs
- pingdotgg/t3code#26463: Changes the shared card metadata layout and empty-metadata behavior.
- pingdotgg/t3code#25251: Introduced card logic that hides an empty metadata line and shortens the intrinsic-size estimate.
- pingdotgg/t3code#26661: Changes the intrinsic-size estimate for card rows with empty metadata.
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to 8a8dc
-
The layout change matches the stated goal without introducing an actionable merge risk.
Pre-merge checks: 
4
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Dismissing prior approval to re-evaluate 8a8dc42
|
Note Written by Verified in a real dev environmentVerified exact head Installed and ran Main reproduced the bug: the completed branchless thread and draft cards measured 60 px, while the branch card measured 78 px. On the PR all three measured 78 px, with provider icons on the bottom metadata line. Checked light and dark appearance at 1280×850, and card heights at 1024×768. A follow-up real Codex turn on the PR returned Before, light: After, light: Before, dark: After, dark: Not verifiedNative iOS/Android, Electron shell integration, macOS/Windows, other providers, and remote/relay/tunnel connections were not exercised. Web and desktop share the changed component; native mobile uses separate rows. No source changes were made, so local static checks were not rerun; the green checks above are the existing CI results. The first PR startup briefly selected the shared home because the checkout is the repository root. It was stopped and restarted with explicit |





Problem
In the New design, a local project thread without a branch shrinks to a 60 px card when its only remaining metadata is the provider icon. Neighboring cards with branches stay 78 px tall. Alex requested the larger, consistent card size.
Change
Keep the standard card height and metadata line, including the provider icon at the bottom. Remove the conditional compact height and its intrinsic-size override.
Scope and approval
Focused restoration of the existing sidebar card layout, requested by Alex. This qualifies as a small visual regression fix without a prior issue. Web and desktop share this component; native mobile has separate thread rows. Existing slim shelf rows retain their layout.
Related: #25605 proposes a broader one-line sidebar design and overlaps this component.
Verification
vp run check:changedpassed formatting, lint, knip, and affected web/scripts typechecks.Model: GPT-6.1 Sol (xhigh reasoning) | Harness: Codex in T3 Code