Skip to content

refactor(mobile): thread rows share one clock and cache SVGs instead of per-row effects - #25612

Merged
juliusmarminge merged 2 commits into
mainfrom
effect/split-mobile-thread-leaves#9
Oct 26, 2026
Merged

juliusmarminge merged 2 commits into
mainfrom
effect/split-mobile-thread-leaves#9

fix(mobile): failed SVG loads retry on remount and thread PR badges k…

6b0a32b
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Oct 26, 2026 in 2m 17s

Effect Service Conventions: All clear

All clear

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 4 changed files (no prior completed review)


🔍 Agent activity — 5 tool calls

💭 Inspecting directives and fields I’m looking at some important lines, especially checking if a lint directive is right next to any comments. Should I use the useNowAfter comment that comes before the directive? It seems like the directive should have its own explanation after the --. I’m considering if the Effect.sync callback has any service boundary issues. I need to ensure everything is clear and that the customer has all the required fields summarized properly.

1. browse_code — apps/mobile/src/lib/clock.ts

2. browse_code — Inspect PR head apps/mobile/src/state/use-thread-pr.ts changed Effect usage and imports: does it introduce any Effect service construction, service dependency injection, bare effect imports, or Effect service convention violation? Return concise evidence.

3. browse_code — apps/mobile/src/state/use-thread-pr.ts

4. browse_code — In apps/mobile/src/state/use-thread-pr.ts is createLinkedPullRequestSummaryAtomFamily a service boundary requiring namespace import, or a pure helper/atom factory? Identify declaration and whether this PR changed its import.

5. browse_code — apps/mobile/src/features/threads/use-visible-second-clock.ts


Agent Credits: 14 credits

Token usage: 66 uncached input · 156,650 cache-read input · 29,703 cache-write input · 2,191 output
Agent Credits may also include non-token charges from external tools such as web research.