Skip to content

test(web): say why the useStableCallback test renders without a router #25493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 26, 2026
+1 −0
Merged

test(web): say why the useStableCallback test renders without a router #25493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/web/src/hooks/useStableCallback.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ describe("useStableCallback", () => {
// child must still reach the handler of the render it commits with.
it("calls the committing render's function from a child layout effect", async () => {
const seen: string[] = [];
// A plain hook test; a router would add its own commits around the rerender.
await using screen = await render(<Parent value="first" seen={seen} />, { router: false });
await screen.rerender(<Parent value="second" seen={seen} />);
expect(seen).toEqual(["first->first", "second->second"]);
Expand Down
Loading