Repository navigation
feat(web): New design brings back color where it means something #25251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
29a5231
999d02f
53c0f87
495a9e8
8c6d390
fef5efd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -175,7 +175,9 @@ function DiffFileHeaderSuffix({ | |
| }) { | ||
| return ( | ||
| <> | ||
| <DiffFilePathCopyButton filePath={filePath} /> | ||
| <span data-diff-copy-path className="inline-flex"> | ||
| <DiffFilePathCopyButton filePath={filePath} /> | ||
| </span> | ||
| {hasStat ? ( | ||
| <DiffFileStatus error={error} truncated={truncated} retry={() => onRetry(filePath)} /> | ||
| ) : null} | ||
|
|
@@ -661,7 +663,7 @@ export default function DiffPanel({ | |
|
|
||
| const headerRow = ( | ||
| <> | ||
| <div className="flex min-w-0 flex-1 items-center gap-3 [-webkit-app-region:no-drag]"> | ||
| <div className="@container/diff-refs flex min-w-0 flex-1 items-center gap-3 [-webkit-app-region:no-drag]"> | ||
| <DropdownMenu> | ||
| <DropdownMenuTrigger | ||
| render={<Button size="xs" variant="secondary" />} | ||
|
|
@@ -717,7 +719,9 @@ export default function DiffPanel({ | |
| <Tooltip> | ||
| <TooltipTrigger | ||
| render={ | ||
| <span className="flex min-w-[min(3rem,calc(100%-2.75rem))] items-center gap-2 overflow-hidden" /> | ||
| // Too narrow for both refs, the New design keeps the target readable and drops | ||
| // the head, which is the thread's own branch. | ||
| <span className="flex min-w-[min(3rem,calc(100%-2.75rem))] items-center gap-2 overflow-hidden redesign:@max-[20rem]/diff-refs:hidden" /> | ||
| } | ||
| > | ||
| <span className="min-w-0 max-w-48 truncate"> | ||
|
|
@@ -729,6 +733,18 @@ export default function DiffPanel({ | |
| {`${selectedGitSource.headRef ?? "HEAD"} → ${selectedGitSource.baseRef}`} | ||
| </TooltipPopup> | ||
| </Tooltip> | ||
| <Tooltip> | ||
| <TooltipTrigger | ||
| render={ | ||
| <span aria-hidden className="hidden redesign:@max-[20rem]/diff-refs:inline" /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔎 Supported by static analysis
Keep the full comparison accessible at narrow widths. At widths of 20rem or less, the head reference is hidden with
|
||
| } | ||
| > | ||
| vs | ||
| </TooltipTrigger> | ||
| <TooltipPopup side="top"> | ||
| {`${selectedGitSource.headRef ?? "HEAD"} → ${selectedGitSource.baseRef}`} | ||
| </TooltipPopup> | ||
| </Tooltip> | ||
| <Combobox | ||
| items={baseRefItems} | ||
| filteredItems={filteredBaseRefItems} | ||
|
|
@@ -743,7 +759,7 @@ export default function DiffPanel({ | |
| > | ||
| <ComboboxTrigger | ||
| render={<Button variant="ghost-muted" size="xs" />} | ||
| className="min-w-9 max-w-48 shrink" | ||
| className="min-w-9 max-w-48 shrink redesign:shrink-0" | ||
| aria-label={`Change comparison target. Currently ${selectedGitSource.baseRef}`} | ||
| > | ||
| <span className="min-w-0 truncate">{selectedGitSource.baseRef}</span> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Low
components/CommandPalette.logic.ts:812When
discovery === null, the palette leavesOpen Source Control settingsunchanged instead of showingOpen Settings -> Source control. The readiness hints still useSource Control, so this replacement does not match them; restore that capitalization in the search string.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: