Skip to content

chore(lint): enforce unicorn/no-useless-fallback-in-spread #25103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Oct 26, 2026
Merged

chore(lint): enforce unicorn/no-useless-fallback-in-spread #25103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a75f4
chore(lint): enforce unicorn/require-module-specifiers
juliusmarminge Oct 25, 2026
135a734
chore(lint): enforce unicorn/no-useless-fallback-in-spread
juliusmarminge Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/mobile/src/state/use-composer-drafts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,7 @@ export function ensureComposerDraftsLoaded(): void {
...Object.fromEntries(
Object.entries(current).map(([instanceId, models]) => [
instanceId,
{ ...(persisted.modelOptionMemory[instanceId] ?? {}), ...models },
{ ...persisted.modelOptionMemory[instanceId], ...models },
]),
),
});
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/src/state/use-model-option-memory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function recordModelOptionsInState(
return {
...state,
[instanceId]: {
...(state[instanceId] ?? {}),
...state[instanceId],
[model]: options,
},
};
Expand Down
1 change: 0 additions & 1 deletion apps/server/src/sourceControl/SourceControlProviderRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
SourceControlProviderError,
type SourceControlProviderDiscoveryItem,
} from "@t3tools/contracts";
import type {} from "@t3tools/contracts";

import * as BuiltInDrivers from "./builtInDrivers.ts";
import { sourceControlDefinitions } from "./sourceControlDefinitions.ts";
Expand Down
1 change: 0 additions & 1 deletion packages/contracts/src/rpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ import {
DeviceSession,
DeviceShutdownInput,
} from "./device.ts";
import {} from "./previewAutomation.ts";
import {
ServerConfigStreamEvent,
DesktopUpdateCommitInput,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/serverSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ function translateLegacyProjectOverridePatch(
for (const [projectId, value] of Object.entries(map)) {
if (canonicalProjectIds.has(projectId)) continue;
const entry: ProjectSettingsOverrides = {
...(entries.get(projectId) ?? currentEntries[projectId] ?? {}),
...(entries.get(projectId) ?? currentEntries[projectId]),
};
if (value === null || value === undefined) {
delete entry[key];
Expand Down
6 changes: 3 additions & 3 deletions scripts/lib/cli-external-packages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ it.layer(NodeServices.layer)("external package dependency closure", (it) => {
if (!manifest) continue;

const declared = {
...(manifest.dependencies ?? {}),
...(manifest.optionalDependencies ?? {}),
...(manifest.peerDependencies ?? {}),
...manifest.dependencies,
...manifest.optionalDependencies,
...manifest.peerDependencies,
};
for (const dependency of Object.keys(declared)) {
if (!isRuntimeExternal(dependency)) {
Expand Down
2 changes: 2 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ export default defineConfig({
perf: "warn",
},
rules: {
"unicorn/no-useless-fallback-in-spread": "error",
"unicorn/require-module-specifiers": "error",
"unicorn/no-array-sort": "off",
"unicorn/consistent-function-scoping": "off",
"oxc/no-map-spread": "off",
Expand Down
Loading