Repository navigation
refactor(web): pull request views record answers and refresh by revision - #24819
Closed
juliusmarminge wants to merge 1 commit into
Closed
juliusmarminge wants to merge 1 commit into
juliusmarminge wants to merge 1 commit into
MacroscopeApp / Macroscope - Correctness Check
succeeded
Oct 25, 2026 in 1m 40s
No issues identified (8 code objects reviewed).
• Merge Base:
f7e4f66
• Head:b2b6463
Details
| ✅ | File Path | U3 Bytes | Comments Posted | Reason |
|---|---|---|---|---|
| ✅ | knip.jsonc |
468 | 0 | |
| ✅ | apps/web/src/components/pullRequest/filesViewedStore.ts |
9812 | ||
| ➖ | apps/web/src/components/diffs/useCodeViewFileReveal.test.ts |
1572 | Excluded by macroscope ignore file | |
| ➖ | apps/web/src/components/pullRequest/filesViewedStore.test.ts |
7516 | Excluded by macroscope ignore file | |
| ➖ | apps/web/src/components/pullRequest/useInlineActionConfirm.browser.test.tsx |
2711 | Excluded by macroscope ignore file | |
| ➖ | apps/web/src/components/pullRequest/guide/PullRequestGuideRunCoordinator.test.ts |
4558 | Excluded by macroscope ignore file | |
| ➖ | apps/web/src/state/pullRequests.test.ts |
12714 | Excluded by macroscope ignore file | |
| ✅ | apps/web/src/state/usePullRequestStack.ts |
1043 | ||
| ✅ | apps/web/src/components/pullRequest/pullRequestDetail.logic.ts |
468 | ||
| ✅ | apps/web/src/components/settings/useScopedSettings.ts |
717 | ||
| ✅ | apps/web/src/components/pullRequest/PullRequestGuideTab.tsx |
1215 | ||
| ➖ | apps/web/src/components/pullRequest/pullRequestDiff.logic.test.ts |
1282 | Excluded by macroscope ignore file | |
| ✅ | apps/web/src/components/ThreadStatusIndicators.tsx |
963 | ||
| ✅ | apps/web/src/components/pullRequest/pullRequestDiff.logic.ts |
2449 | ||
| ➖ | apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts |
977 | Excluded by macroscope ignore file | |
| ✅ | apps/web/src/components/pullRequest/LinkPullRequestDialog.tsx |
1077 | ||
| ➖ | apps/web/src/components/pullRequest/pullRequestList.logic.test.ts |
5264 | Excluded by macroscope ignore file | |
| ✅ | apps/web/src/components/pullRequest/guide/GuideTour.tsx |
2595 | ||
| ✅ | apps/web/src/components/diffs/useCodeViewFileReveal.ts |
2794 | ||
| ✅ | apps/web/src/components/pullRequest/guide/guideRunStore.ts |
2172 | ||
| ✅ | apps/web/src/components/pullRequest/PullRequestCommentBody.tsx |
1726 | ||
| ✅ | apps/web/src/components/pullRequest/useInlineActionConfirm.ts |
3597 | ||
| ✅ | apps/web/src/components/pullRequest/pullRequestList.logic.ts |
5484 | ||
| ✅ | packages/client-runtime/src/state/pullRequests.ts |
4848 | ||
| ✅ | apps/web/src/components/pullRequest/usePullRequestDetail.ts |
4615 | ||
| ✅ | apps/web/src/hooks/useSettings.ts |
7148 | ||
| ✅ | apps/web/src/components/pullRequest/usePullRequestFilesViewed.ts |
6757 | ||
| ✅ | apps/web/src/state/pullRequests.ts |
20902 | 0 | |
| ✅ | apps/web/src/components/pullRequest/PullRequestsColumn.tsx |
7187 | 0 | |
| ➖ | apps/web/src/components/pullRequest/PullRequestCodeTab.browser.test.tsx |
5179 | Excluded by macroscope ignore file | |
| ✅ | apps/web/src/components/pullRequest/guide/PullRequestGuideRunCoordinator.tsx |
6261 | ||
| ✅ | apps/web/src/components/RightPanelTabs.tsx |
6788 | 0 | |
| ➖ | apps/web/src/hooks/useSettings.favorites.browser.test.tsx |
5755 | Excluded by macroscope ignore file | |
| ✅ | apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx |
15109 | ||
| ✅ | apps/web/src/components/pullRequest/PullRequestCodeTab.tsx |
14753 | 0 | |
| ✅ | apps/web/src/components/pullRequest/PullRequestsPage.tsx |
24933 |
Billed Total: 40.06KB of diff | $1.60
Filtered Issues Details
apps/web/src/components/pullRequest/PullRequestCodeTab.tsx
- line 1245: Reveal requests never become answered:
useCodeViewFileRevealreturnsreveal.request(...), and that implementation has no return value even when it successfully callsscrollTo. ConsequentlyrevealFile(...)is always undefined and this condition never records the nonce. After a reveal, changing the items (for example collapsing the revealed file) runsanswerRevealagain, scrolls back to that file and unfolds it again. Record successful completion through an actual acknowledgement rather than testing this void return value. [ Already posted ]
Loading