Skip to content

fix(web): keep blockquote text readable in every theme - #24036

Merged
Yash-Singh1 merged 1 commit into
mainfrom
t3/fix-blockquote-theming
Oct 23, 2026
Merged

Yash-Singh1 merged 1 commit into
mainfrom
t3/fix-blockquote-theming

Conversation

@Yash-Singh1

Copy link
Copy Markdown
Collaborator

Problem

Blockquote text and quote bars used muted theme colors that could be hard to read in some themes. Composer quotes also looked disabled while being edited.

Change

Blockquotes now inherit their surrounding text color, and their bars use that color at 35% opacity. This keeps quotes readable and consistent across chat, Markdown previews, and composer drafts.

Scope and approval

This is a focused fix for an obvious styling bug in the shared web and desktop UI.

Verification

Checked messages, nested quotes, and composer drafts across all 12 built-in theme and appearance combinations. check:changed passed.

GPT-6 via Codex

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 23, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This focused CSS fix changes the default appearance of blockquotes in both rendered chat Markdown and composer drafts across themes. Because it changes product defaults on existing user-facing paths, human review is required under the configured criteria.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between d7a8d6f and a2778f6.

📒 Files selected for processing: 1
  • apps/web/src/index.css

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The shared blockquote styling now uses inherited text color and a border mixed from the current text color. The composer-specific foreground override was removed.

Changes: Blockquote styling

Layer / File(s) Summary
Update shared blockquote styles
apps/web/src/index.css
The shared blockquote rule uses inherited text color and a border mixed from the current text color. The composer-specific foreground override is removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: yzn-h

Merge Risk: ⚪ Minimal · up to a2778

The blockquote styling change has no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title is concise, uses conventional commit format, and clearly describes the blockquote readability fix.
Description check Passed The description covers the problem, change, scope justification, verification steps, observed results, and agent attribution. It does not include the before-and-after screenshots required for UI chang…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, change, scope justification, verification steps, observed results, and agent attribution. It does not include the before-and-after screenshots required for UI changes, but the description is otherwise complete and focused.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Yash-Singh1
Yash-Singh1 merged commit 1df9c32 into main Oct 23, 2026
29 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3/fix-blockquote-theming branch October 23, 2026 12:06
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 23, 2026
## What's Changed
* fix(server): avoid full shell read on resume by @Yash-Singh1 in pingdotgg/t3code#23987
* test: delete low-value tests and dead test-only exports by @t3dotgg in pingdotgg/t3code#24058
* test(server): restore DST scheduling tests deleted in the test snap by @t3dotgg in pingdotgg/t3code#23991
* test(web): restore project settings permission tests deleted in the test snap by @t3dotgg in pingdotgg/t3code#24011
* test(mobile): restore clipboard secret-redaction test deleted in the test snap by @t3dotgg in pingdotgg/t3code#23980
* fix(web): Cmd+B toggles the sidebar unless text is selected by @t3dotgg in pingdotgg/t3code#24063
* fix(server): agent-browser and Chrome no longer outlive the agent that started them by @josephv123 in pingdotgg/t3code#21299
* test(client-runtime): restore render scheduler tests deleted in the test snap by @t3dotgg in pingdotgg/t3code#23977
* fix(web): cmd+k search hides subagents and favors recent, whole-word matches by @t3dotgg in pingdotgg/t3code#24032
* test(lint): new polling loops in tests now fail lint by @t3dotgg in pingdotgg/t3code#23983
* ci: unused dependency patches fail in check:changed, not after push by @t3dotgg in pingdotgg/t3code#23988
* fix(desktop): PDFs in the preview can be annotated by @shivamhwp in pingdotgg/t3code#24022
* fix(web): instructed compact runs without a bare compaction first by @juliusmarminge in pingdotgg/t3code#24008
* fix(desktop): reduce app crashes when a preview tab's renderer dies during agent screenshots by @shivamhwp in pingdotgg/t3code#24056
* fix(server): Stop stops a thread's subagents again by @shivamhwp in pingdotgg/t3code#23886
* fix(desktop): a stuck quit no longer leaves the app unkillable by @shivamhwp in pingdotgg/t3code#23873
* fix(web): keep blockquote text readable in every theme by @Yash-Singh1 in pingdotgg/t3code#24036
* fix(bitbucket): stop the startup sweep from flooding Bitbucket with 429s by @shivamhwp in pingdotgg/t3code#23889
* fix(web): screen readers hear when the open thread starts, needs you or finishes by @shivamhwp in pingdotgg/t3code#23752
* perf(web): reduce allocations in streaming timeline scans by @UtkarshUsername in pingdotgg/t3code#23739
* perf(web): reuse a collator when sorting changed-file trees by @UtkarshUsername in pingdotgg/t3code#23776
* perf(scripts): check:changed finishes in about 10 s by @t3dotgg in pingdotgg/t3code#23581


**Full Changelog**: pingdotgg/t3code@v0.1.3-nightly.20261023.3566...v0.1.3-nightly.20261023.3579

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.3-nightly.20261023.3579
Pipyakas pushed a commit to Pipyakas/t3code that referenced this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant