[only21mil]

Problem

Typing on a numeric keypad in the iOS device preview does nothing. The preview consumes each keyboard event, but the shared iOS HID lookup has no Numpad* entries, so sendKey drops both the press and release. Top-row digits and the main Enter key already work.

To reproduce, open an iOS simulator in the Device panel, focus a text field, and type digits or press Enter on a numeric keypad.

Change

Add 17 keypad entries to the existing HID table: digits, Enter, decimal, equal and the four arithmetic operators. Use the standard keyboard/keypad usages, preserving keypad identity without synthesizing shifted main-keyboard keys. The usages match Apple's HID definitions.

The shared transport serves web, desktop and the mobile device WebView. The packet format and server stay unchanged. Android follows a separate mapping and is unchanged.

Scope and approval

This is a small, focused fix for an obvious omission in an existing input path. It adds table entries and one protocol regression test. No setting, UI control or protocol extension is introduced. No issue for this defect was found.

Verification

Built production web apps from base a8bb769d65 and candidate ff46c9f0df, with separate source copies and server state. Chrome 154 on Linux drove the Device panel, streaming Safari on an iOS 26.5 simulator. No provider run was started.

Chrome's keyboard automation sent the same Numpad* key codes the input handler receives from a numeric keypad. Starting with a top-row 9, keypad 123.45 leaves the base field at 9; the candidate shows 9123.45. Keypad Enter does nothing on the base and submits Safari's search on the candidate. The candidate also enters +, -, * and / from the keypad.

These recordings show the Device panel on a second fresh iOS 26.5 simulator. Each caption names the build and the keys sent. A grey box covers the search results that load after Enter.

MP4 copies: base recording, candidate recording.

Base: the top-row 9 works, but keypad 123.45 and Enter leave it unchanged.

Candidate: the same digit sequence produces 9123.45.

Candidate: the four keypad operators append +-*/.

Candidate: keypad Enter submits the query in Safari.

Focused checks:

• In packages/client-runtime, pnpm exec vp test run src/device/stream.test.ts -t 'encodes keypad presses': the new test fails on the base, receiving 4 packets instead of 38. Only the existing top-row digit and main Enter are sent.
• In the same package, pnpm exec vp test run src/device/stream.test.ts: all 15 tests pass on the candidate. The regression decodes the binary packet tag and JSON payload for 17 keypad keys and the two existing controls, in both phases. It uses no timer waits or mock-call assertions.
• pnpm run typecheck in that package: passes.
• From the repository root, pnpm exec vp lint packages/client-runtime/src/device/stream.ts packages/client-runtime/src/device/stream.test.ts and pnpm exec vp fmt --check on those files: pass.
• pnpm exec vp build in each production copy's apps/web: both pass.

The new regression fails on the base.

All device-stream tests pass on the candidate.

Not checked: a physical USB keyboard, the mobile WebView with an attached keyboard, and Android UI. NumpadEqual passes the protocol regression, but Chrome's automation rejects that key name, so it was not exercised on the simulator. The native run covers digits 1–5, decimal, the four arithmetic operators and Enter; the regression covers all 17 added usages.

Prior PRs: no earlier PR for this defect found. #21200 by Reda Hilal fixes keypad app-zoom shortcuts, a different input path. This change reuses no code from it.

Production fix, tests, PR description and images written with GPT-6.1 Sol in T3 Code Nightly.

🤖 Generated with GPT-6.1 Sol in T3 Code Nightly

[macroscopeapp]

Approvability

Verdict: Approved at ff46c9f

Macroscope's review found this PR approvable — Adds standard HID mappings for numeric keypad keys so the existing iOS simulator input path forwards them instead of dropping them. The accompanying regression test covers all new mappings and existing key behavior, with no protocol, server, configuration, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6de4fc0c-f83c-46f7-a5e6-b99273d14900

📥 Commits

Reviewing files that changed from the base of the PR and between 3690c86 and ff46c9f.

📒 Files selected for processing: 2

• packages/client-runtime/src/device/stream.test.ts
• packages/client-runtime/src/device/stream.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

The HID usage map now includes numpad arithmetic keys, Enter, digits, Decimal, and Equal. A mocked iOS stream test checks packets for keypad key down and up events.

Changes: Keypad HID Support

Layer / File(s)	Summary
Keypad HID mapping and stream validation packages/client-runtime/src/device/stream.ts, packages/client-runtime/src/device/stream.test.ts	HID_USAGE_BY_CODE adds keypad key mappings. The mocked iOS stream test checks that key down and up events produce 0x06-prefixed JSON packets with the expected HID usages.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to ff46c

The keypad mapping and its packet test appear ready for normal merge checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title is concise, uses the repository's conventional format, and clearly identifies the main change: forwarding numeric keypad keys to iOS simulators.
Description check		The description includes all required sections. It explains the problem and reproduction steps, the implementation, scope and approval rationale, focused verification results, limitations, and test ev…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes all required sections. It explains the problem and reproduction steps, the implementation, scope and approval rationale, focused verification results, limitations, and test evidence.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

No changed behavior could be exercised on this Linux Boat VM. This is an unverifiable result, not a runtime pass.

Inspected the description, full diff, commits, discussion, reviews and inline comments at ff46c9f0df495920fd7ed8663e8934d7745bf828. The PR is open and contains no commits by juliusmarminge or t3dotgg. The diff adds 17 keypad HID mappings and a regression in the existing stream test file. CI reports 28 successful checks, which does not prove native input works.

The environment check failed before app setup:

$ uname -s -m
Linux x86_64
$ timeout 10 xcrun simctl list devices
timeout: failed to run command ‘xcrun’: No such file or directory

The local device host explicitly rejects iOS on non-macOS hosts with iOS Simulators need macOS with Xcode. No remote macOS simulator host was supplied.

Inspection and prerequisite transcript

Not verified

Original-bug reproduction on github/main, candidate keypad input through the running Device panel, digits, operators, decimal, Equal, Enter and releases. Nearby top-row digits, main Enter, modifier behavior and Android behavior also remain unverified. Native mobile clients and physical keyboards were not exercised.

No installs, dev servers, provider turns, local checks, screenshots or recordings were produced because the required native endpoint is unavailable. A Codex turn would not exercise this keyboard transport. The author’s existing captures were not reused as proof of this run. No source changes or pushes were made.

Verification requires a real macOS/Xcode simulator host: compare main and this exact head through the Device panel, using a focused simulator text field and matching keypad and main-keyboard input, and capture the resulting text and Enter submission.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

no changed behavior could be exercised in this run. result: unverifiable, with no runtime pass claimed.

inspected the open pr at ff46c9f0df495920fd7ed8663e8934d7745bf828, including its description, two commits, full diff, discussion, reviews and empty inline-comment list. neither juliusmarminge nor t3dotgg authored its commits. the diff adds 17 keypad HID mappings to the shared ios transport and a regression in the existing test file. ci currently reports 28 successful checks; this does not prove native input works.

this vm fails the native prerequisite:

$ uname -s -m
Linux x86_64
$ timeout 10 xcrun simctl list devices
timeout: failed to run command ‘xcrun’: No such file or directory

the device host rejects ios on non-macos hosts with iOS Simulators need macOS with Xcode. no remote macos simulator endpoint was supplied.

prerequisite and inspection transcript

Not verified

main reproduction and candidate behavior through the running device panel remain unverified: keypad digits, decimal, operators, equal, enter and releases. nearby top-row digits, main enter and modifiers remain unverified, as do android, native mobile clients and physical keyboards.

no worktree installs, dev servers, provider turns, local checks, screenshots or recordings were produced because the required native endpoint is unavailable. a codex turn would not exercise the changed keyboard transport. no source changes or pushes were made, and no task-owned processes remain.

verification needs a macos/xcode simulator host. compare main and this exact head through the device panel with a focused text field, checking keypad input and main-keyboard controls. the existing author captures were not reused as evidence for this run.