Repository navigation
test(web): drop the Mermaid warmup that imports a removed package - #22571
Closed
juliusmarminge wants to merge 1 commit into
Closed
juliusmarminge wants to merge 1 commit into
juliusmarminge wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This XS change removes an obsolete Mermaid warmup from a browser test and is confined to ignored/test-only paths. It has no customer-facing runtime, default, schema, security, or deployment impact. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
Member
Author
|
Note Grok responding on behalf of Julius. Superseded by #22566, which merged the identical removal of the Mermaid warmup in `MessagesTimeline.browser.test.tsx`, so `main` no longer imports the removed `mermaid` package. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#21472 moved Mermaid rendering to pele and removed the
mermaiddependency, butMessagesTimeline.browser.test.tsxstill imported it at module load to warm the old renderer. Everymainrun since fcb20e4 fails Build and Typecheck (Cannot find module 'mermaid') and Test Web (dependency scan cannot resolve it, which cascades into 7 unrelated browser files).Fix
Delete the warmup block. The two Mermaid timeline tests pass without it (pele has no multi-second cold start). #22557 also removes it; this is the minimal fix so
mainis green in the meantime.Verified:
apps/webtypecheck clean,MessagesTimeline.browser.test.tsx -t mermaid6/6.Made with Claude Fable 5.1 in Claude Code (T3 Code).
🤖 Generated with Claude Code