Skip to content

test(web): drop the Mermaid warmup that imports a removed package - #22571

Closed
juliusmarminge wants to merge 1 commit into
mainfrom
fix/mermaid-warmup-import
Closed

juliusmarminge wants to merge 1 commit into
mainfrom
fix/mermaid-warmup-import

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

Problem

#21472 moved Mermaid rendering to pele and removed the mermaid dependency, but MessagesTimeline.browser.test.tsx still imported it at module load to warm the old renderer. Every main run since fcb20e4 fails Build and Typecheck (Cannot find module 'mermaid') and Test Web (dependency scan cannot resolve it, which cascades into 7 unrelated browser files).

Fix

Delete the warmup block. The two Mermaid timeline tests pass without it (pele has no multi-second cold start). #22557 also removes it; this is the minimal fix so main is green in the meantime.

Verified: apps/web typecheck clean, MessagesTimeline.browser.test.tsx -t mermaid 6/6.

Made with Claude Fable 5.1 in Claude Code (T3 Code).

🤖 Generated with Claude Code

#21472 moved Mermaid rendering to pele and removed the mermaid dependency, but the
timeline browser test still imported it to warm the old renderer. Every main run since
fcb20e4 fails typecheck and the web dependency scan on that import.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 21, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 21, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 150cfdc

Macroscope's review found this PR approvable — This XS change removes an obsolete Mermaid warmup from a browser test and is confined to ignored/test-only paths. It has no customer-facing runtime, default, schema, security, or deployment impact.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 250b96ad-99c3-4319-bf80-befd0383d45c
📥 Commits

Reviewing files that changed from the base of the PR and between 043c9c3 and 150cfdc.

📒 Files selected for processing: 1
  • apps/web/src/components/chat/MessagesTimeline.browser.test.tsx
💤 Files with no reviewable changes: 1
  • apps/web/src/components/chat/MessagesTimeline.browser.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The browser test no longer initializes Mermaid or renders a flowchart at module load.

Changes: Browser test setup

Layer / File(s) Summary
Remove module-load warmup
apps/web/src/components/chat/MessagesTimeline.browser.test.tsx
The test no longer initializes Mermaid or renders a flowchart during module loading.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 150cf

No actionable issue remains from this change; it is ready for normal merge checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the removal of the obsolete Mermaid warmup from the web test.
Description check Passed The description explains the problem, fix, affected dependency, related work, verification results, and agent attribution. It uses "## Fix" instead of "## Change" and does not include a separate "## S…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, fix, affected dependency, related work, verification results, and agent attribution. It uses "## Fix" instead of "## Change" and does not include a separate "## Scope and approval" section, but it provides enough scope context for this focused fix.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge

Copy link
Copy Markdown
Member Author

Note

Grok responding on behalf of Julius.

Superseded by #22566, which merged the identical removal of the Mermaid warmup in `MessagesTimeline.browser.test.tsx`, so `main` no longer imports the removed `mermaid` package. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant