Skip to content

fix(install): accept backslashes and newlines in T3 home paths #22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lucenx9 wants to merge 4 commits into from
+156 −2
Closed

fix(install): accept backslashes and newlines in T3 home paths #22415

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94a84ee
fix(install): accept backslashes and newlines in T3 home paths
Lucenx9 Oct 20, 2026
9bb92c7
fix(install): preserve checksum regressions on current main
Lucenx9 Oct 23, 2026
c57bdc3
test(install): verify checksums without diagnostic suppressions
Lucenx9 Oct 23, 2026
e4c7fe6
test(install): exercise available checksum tools
Lucenx9 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,11 @@ case "$(uname -m)" in
*) fail "unsupported architecture $(uname -m)" ;;
esac
command -v tar >/dev/null 2>&1 || fail "tar is required"
# Hash stdin so filename escaping cannot add a backslash before the digest.
if command -v sha256sum >/dev/null 2>&1; then
checksum() { sha256sum "$1" | cut -d' ' -f1; }
checksum() { sha256sum < "$1" | cut -d' ' -f1; }
elif command -v shasum >/dev/null 2>&1; then
checksum() { shasum -a 256 "$1" | cut -d' ' -f1; }
checksum() { shasum -a 256 < "$1" | cut -d' ' -f1; }
else
fail "sha256sum or shasum is required"
fi
Expand Down
24 changes: 15 additions & 9 deletions scripts/install.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ import * as NodePath from "node:path";
import { describe, expect, it } from "vite-plus/test";

describe.skipIf(HostProcess.Platform.defaultValue() !== "linux")("installer terminal", () => {
it.each([false, true])(
"preserves download and install behavior (HTTP failure: %s)",
async (fail) => {
it.each([
{ fail: false, homeName: "home" },
{ fail: true, homeName: "home" },
{ fail: false, homeName: "home\\data" },
{ fail: false, homeName: "home\ndata" },
])(
"preserves download and install behavior (HTTP failure: $fail, home: $homeName)",
async ({ fail, homeName }) => {
const root = await NodeFSP.mkdtemp(NodePath.join(NodeOS.tmpdir(), "t3-install-progress-"));
const t3Home = NodePath.join(root, homeName);
const version = "1.2.3";
const stem = `t3-${version}-linux-${HostProcess.Architecture.defaultValue()}`;
const archiveName = `${stem}.tar.gz`;
Expand Down Expand Up @@ -60,7 +66,7 @@ describe.skipIf(HostProcess.Platform.defaultValue() !== "linux")("installer term
TERM: "xterm",
NO_COLOR: "1",
T3CODE_VERSION: version,
T3CODE_HOME: NodePath.join(root, "home"),
T3CODE_HOME: t3Home,
T3CODE_INSTALL_BIN_DIR: NodePath.join(root, "bin"),
T3CODE_RELEASE_BASE_URL: `http://127.0.0.1:${address.port}`,
},
Expand All @@ -80,15 +86,15 @@ describe.skipIf(HostProcess.Platform.defaultValue() !== "linux")("installer term
child.on("error", reject);
child.on("close", resolve);
});
const versions = NodePath.join(root, "home/runtime/versions");
const versions = NodePath.join(t3Home, "runtime/versions");
if (fail) {
expect(code).not.toBe(0);
expect(output).toContain("500");
expect(output).not.toContain("100%");
expect(output).not.toContain("Installed T3 Code");
expect(await NodeFSP.readdir(versions)).toEqual([]);
} else {
expect(code).toBe(0);
expect(code, output).toBe(0);
expect(sawPartialProgress).toBe(true);
expect(output).toContain("100%");
expect(output).toContain("0.1 / 0.1 MB");
Expand All @@ -102,9 +108,9 @@ describe.skipIf(HostProcess.Platform.defaultValue() !== "linux")("installer term
}).trim(),
).toBe("t3 v1.2.3");
expect(await NodeFSP.readdir(versions)).toEqual([version]);
expect(
await NodeFSP.readFile(NodePath.join(root, "home/runtime/launchers"), "utf8"),
).toBe(`${NodePath.join(root, "bin/t3")}\n`);
expect(await NodeFSP.readFile(NodePath.join(t3Home, "runtime/launchers"), "utf8")).toBe(
`${NodePath.join(root, "bin/t3")}\n`,
);
}
} finally {
if (child.exitCode === null) child.kill();
Expand Down
Loading