Repository navigation
fix(server): retain relay unregister events at normal log level #21650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maria-rcks
merged 6 commits into
pingdotgg:main
from
only21mil:a6-12/relay-unregister-log-level
Oct 30, 2026
+110
−2
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e5bff03
fix(server): retain relay unregister events at normal log level
only21mil b571f43
Merge main (94827737ea) into a6-12/relay-unregister-log-level
only21mil 9d57314
Merge main (05696c636e) into a6-12/relay-unregister-log-level
only21mil 9dd6cb0
test(server): prove relay unregistration leaves registration pending
only21mil acf692f
chore: merge main into relay unregister logging fix
maria-rcks 6e03780
test(server): preserve warnings for relay unregister output
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove raw relay output from the Info log.
This branch passes
attributes.outputtoEffect.logInfo. The value contains the full child-process line; the code redacts onlyconnectorToken. If an unregistration line contains another sensitive value, normal Info logs retain it. Log bounded fields instead, and update the test that expects the raw line. As per coding guidelines, “Attributes and log annotations stay bounded: no raw payloads, command arguments or output.” The path instructions also require log annotations to “exclude credentials or raw command output.”Sources: Coding guidelines, Path instructions