Repository navigation
feat(web): preview archives, sqlite databases, and decoded images #21467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
d34e168
feat(web): preview archives, sqlite databases, and decoded images
maria-rcks 26597b3
fix(web): keep binary previews lazy and align heif file icons
maria-rcks 1b88a01
fix(web): keep lazy image decoding compatible with react compiler
maria-rcks 98422ab
test(shared): cover binary file downloads across clients
maria-rcks 4e08914
chore: merge t3/large-file-previews
maria-rcks 54d0a12
chore: merge large file preview base
maria-rcks 5de6c34
chore: merge t3/large-file-previews
maria-rcks b5891fe
chore: merge t3/large-file-previews
maria-rcks 5b24af6
fix(web): bound binary parsers and preserve archive entries
maria-rcks fbcbe07
chore: merge large file preview fixes
maria-rcks 53395e9
fix(web): preserve pax payloads and generated sqlite columns
maria-rcks 2ebed51
chore: merge tall row preview fix
maria-rcks 1ca6db3
chore: merge native row scrolling fix
maria-rcks c8957ed
fix(web): preserve pax attributes and sqlite table names
maria-rcks d38615d
chore: merge trailing row scrolling fix
maria-rcks 337b5c1
test(web): allow cold preview workers to finish in CI
maria-rcks b1aeeb6
chore: merge current large file preview base
maria-rcks 04bce05
fix(web): preserve invalid office document errors
maria-rcks 1ce8c0a
chore: merge t3/large-file-previews
maria-rcks 286339f
chore: merge large file preview fixes
maria-rcks 54bf5e8
fix(web): validate zip64 targets and retry binary previews
maria-rcks c73439a
fix(web): carry workspace refresh fixes into binary previews
maria-rcks 0be0d40
fix(web): carry parser notices into binary previews
maria-rcks a0478a5
chore: merge large previews into binary file previews
maria-rcks d937010
chore: merge large preview test fix
maria-rcks 1e80fa9
chore: merge large previews
maria-rcks 132ee24
fix(web): preserve sqlite table picker keyboard focus
maria-rcks 844e590
chore: merge lazy large previews into binary file previews
maria-rcks 1d674ea
fix(shared): remove unused preview metadata reexports
maria-rcks db71405
chore: merge inline audio pills
maria-rcks 7d42822
fix(web): merge audio duration readiness into binary previews
maria-rcks 64b685d
fix(web): merge large file viewer improvements into binary previews
maria-rcks de6bd02
fix(web): add image fit controls and binary preview metadata
maria-rcks 2612448
fix(web): merge office engines into binary file previews
maria-rcks 199e984
chore: merge large file preview fixes
maria-rcks 5550a2f
chore: merge file preview review fixes
maria-rcks dd7b6b2
chore: merge wrapped file tail fixes
maria-rcks 32de835
chore: merge t3/large-file-previews
maria-rcks 33c7a0c
fix(web): align binary previews with current lint rules
maria-rcks 13fd5ec
chore: merge t3/large-file-previews
maria-rcks 51f5de7
chore: merge t3/large-file-previews
maria-rcks dec4674
chore: merge t3/large-file-previews
maria-rcks 12e7e98
fix(web): reject redirected ZIP64 archive comments
maria-rcks 37842c9
chore: merge t3/large-file-previews
maria-rcks d47f223
chore: merge t3/large-file-previews
maria-rcks 5d8f1ac
chore: merge Office fixes through large file previews
maria-rcks d4b9a8a
refactor(web): reuse ZIP directory preflight for binary previews
maria-rcks c1deef5
chore: merge large file preview fixes
maria-rcks ce3d108
chore: reconcile binary viewer lockfile peers
maria-rcks 4f51d3d
chore: merge latest large file base
maria-rcks 0300612
chore: retain mobile audio compatibility
maria-rcks 12a35e1
chore: merge large file preview base
maria-rcks fe6181a
Merge branch 't3/large-file-previews' into t3/binary-file-previews
maria-rcks bd20ac6
chore: merge large file preview updates
maria-rcks 1164429
fix(web): copy cached tar entry bytes
maria-rcks f914a03
chore: merge large file preview retry
maria-rcks 2c9fca5
chore: merge large file previews into binary file previews
maria-rcks c031c7d
chore(web): binary viewer effects state their reasons
maria-rcks 1b0022d
chore: merge current large file base into binary file previews
maria-rcks 4313a53
Merge branch 'fix/large-r6' into fix/binary-r6
maria-rcks 39cb737
Merge branch 'fix/large-r6' into fix/binary-r6
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -334,6 +334,7 @@ describe("pickProjectFavicon", () => { | |
| "gif", | ||
| "ico", | ||
| "heic", | ||
| "heif", | ||
| "jpeg", | ||
| "jpg", | ||
| "png", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { lazy, Suspense } from "react"; | ||
|
|
||
| import { FileSurfaceLoading } from "./fileSurfaceChrome"; | ||
|
|
||
| const BinaryViewer = lazy(() => import("./BinaryViewer")); | ||
|
|
||
| export function BinaryFilePreview(props: { | ||
| readonly src: string; | ||
| readonly name: string; | ||
| readonly kind: "archive" | "sqlite"; | ||
| }) { | ||
| return ( | ||
| <Suspense fallback={<FileSurfaceLoading />}> | ||
| <BinaryViewer key={props.src} {...props} /> | ||
| </Suspense> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.