Skip to content

fix(mobile): usage chart bars round at the top instead of the bottom #21383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 3 commits into from
Oct 27, 2026
Merged

fix(mobile): usage chart bars round at the top instead of the bottom #21383

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ea2a2e
fix(mobile): usage chart bars round at the top instead of the bottom
adityavardhansharma Oct 19, 2026
6ed05ac
Merge branch 'main' into fix/mobile-usage-chart-bar-rounding
adityavardhansharma Oct 19, 2026
9e26f16
Merge branch 'main' into fix/mobile-usage-chart-bar-rounding
adityavardhansharma Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/mobile/src/features/usage/UsageDailyChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,15 @@ export function UsageDailyChart({ days, daily, metric, height }: UsageDailyChart
return (
<View style={{ height }} className="flex-row items-end gap-px">
{/* column-reverse stacks the bottom-first provider values upward
without reversing the array (Hermes lacks Array#toReversed). */}
without reversing the array (Hermes lacks Array#toReversed).
Each column is only as tall as its stack so the rounding clips the
bar's top, not empty space above it. */}
{chartDays.map((day) => (
<View key={day.day} className="h-full flex-1 flex-col-reverse overflow-hidden rounded-sm">
<View
key={day.day}
style={{ height: max === 0 ? 0 : (day.total / max) * height }}
className="flex-1 flex-col-reverse overflow-hidden rounded-t-sm"
>
{day.values.map((entry) => (
<View
key={entry.provider}
Expand Down
Loading