fix(ci): repair main lint, web, and server/mobile test regressions

[luke2x]

Problem

main is red at e2cc34f1e4 for five independent reasons. None is a product bug; each is stale code or a missed cleanup from a recent merge.

Failing area	Root cause	Effect
Lint, Test Server 4/7	GrokAdapterV2.test.ts imports effect/Path twice, left by the merge of #20881 and #20180	Duplicate-identifier lint error and a parse failure in two server shards
Build/Typecheck, Test Web	#20944 removed react-test-renderer from apps/web while FileBrowserPanel.test.tsx and AttachmentImage.test.tsx still import it	TS2307 plus failed web tests
Mobile Test	#15674 changed single tool calls to render as activity-group, but the completed-HTML-render assertion still expected work-toggle	One stale expectation fails the mobile suite
Server Test 4	ThreadFork.execution.test.ts still expected opt-out to drop the link's endedWatch; the orchestrator now preserves the watch that just ended	One stale assertion fails a server shard
Mobile Test (settings)	The two settings test files still mock the old components/AppText and components/ScreenScrollView paths, and the source-control route eagerly imports DatabaseStorageNotice	Nine settings assertions fail before reaching their subject

This is the same two-file settings repair carried by #21280; it is included here so this branch restores main independently of merge order.

Change

• Remove the duplicate Path import in apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.test.ts.
• Restore react-test-renderer and @types/react-test-renderer in apps/web/package.json and the lockfile. Only those two node-rendered test files still use them; migrating them to the browser project can be a separate follow-up rather than blocking the CI repair.
• Update the mobile expectation to activity-group and change continuesWorkLog to true, matching the current lone-call row contract.
• Update the fork test to expect the original link plus endedWatch: <the ended watch>, matching withPullRequestWatch's behavior.
• Point the two settings test mocks at components/ui and stub DatabaseStorageNotice, matching the production module moves.

Scope and approval

Four minimal main-only repairs under the small obvious-fix exception. No production behavior, defaults, API, or new workflow changes. The only dependency change restores a package that existing tests still import.

Verification

Command	Result
vp test run apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.test.ts	20 passed
vp test run apps/server/src/orchestration-v2/ThreadFork.execution.test.ts	7 passed
vp test run apps/mobile/src/lib/threadActivity.test.ts	98 passed
vp test run apps/mobile/src/features/settings/components/BranchNamingSettings.test.tsx apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.test.tsx	10 passed
vp test run apps/web/src/components/files/FileBrowserPanel.test.tsx apps/web/src/components/media/AttachmentImage.test.tsx	10 passed
vp run --filter @t3tools/web typecheck	passed
Focused vp lint on the changed files	passed
vp fmt --check on the changed files	passed

With this change all previously failing main checks are covered by the branch: lint, web typecheck, web tests, mobile thread activity, the settings regressions, and the fork watch assertion.

Implemented and tested with DeepSeek V4.1 Flash 1017 in T3 Code.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-18T20:33:20.377783Z	f84e860	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[macroscopeapp]

Approvability

Verdict: Approved at f84e860

Macroscope's review found this PR approvable — The PR is limited to ignored test and dependency metadata paths, restoring CI checks without changing product behavior or defaults. It introduces no static-analysis suppressions, production infrastructure changes, or new capability.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7f0cfd05-45f7-4916-ba9e-707a709b24f3

📥 Commits

Reviewing files that changed from the base of the PR and between e2cc34f and 0a38a0b.

⛔ Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing: 4

• apps/mobile/src/lib/threadActivity.test.ts
• apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.test.ts
• apps/server/src/orchestration-v2/ThreadFork.execution.test.ts
• apps/web/package.json

💤 Files with no reviewable changes: 1

• apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The changes update mobile and server test expectations, remove a duplicate import from a server test, and add React test-renderer packages to web development dependencies.

Changes: Mobile activity test

Layer / File(s)	Summary
Activity render expectation apps/mobile/src/lib/threadActivity.test.ts	The test expects activity groups before and after the HTML render. It also expects the preceding group to continue the work log.

Server test updates

Layer / File(s)	Summary
Test expectations and import apps/server/src/orchestration-v2/ThreadFork.execution.test.ts, apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.test.ts	The fork watch test expects the pull-request link to retain the fork’s ended watch. The Grok adapter test removes a duplicate effect/Path import.

Web test dependencies

Layer / File(s)	Summary
Test-renderer dependencies apps/web/package.json	Adds react-test-renderer and @types/react-test-renderer to development dependencies.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: t3dotgg, jakeleventhal, scottn-pv

Merge Risk: ⚪ Minimal · up to 0a38a

The changes update tests and add web test tooling without changing production behavior. The fork-watch expectation matches the implementation, and no actionable merge-blocking risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 0a38a

The change affects 3 systems.

Changed systems: apps/server, apps/mobile, apps/web

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 2 changed files map to changed impact.
• observed — apps/mobile (service) was modified; 1 changed file maps to changed impact.
• observed — apps/web (ui) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in apps/mobile/src/lib/threadActivity.test.ts: The test now expects activity groups before and after the HTML render, rather than work toggles, and expects the preceding group to have continuesWorkLog: true instead of unset.
• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.test.ts: Removed the duplicate effect/Path import; the earlier import remains in the file.
• observed — Modified behavior in apps/server/src/orchestration-v2/ThreadFork.execution.test.ts: After opting out of watching, the test now expects the fork’s pull-request link to retain the watch that was started on the fork and then ended, rather than expecting the original fork pull-request state unchanged.
• observed — Modified behavior in apps/web/package.json: Added the React test-renderer type definitions and package to devDependencies; the existing dependencies in this range remain unchanged.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly summarizes the main changes: repairing lint, web, server, and mobile test regressions in CI.
Description check		The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the causes, fixes, scope, focused test results, and agent details.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[juliusmarminge]

Note

Grok responding on behalf of Julius.

Thanks for pulling all of these together! Every repair here has now landed on main separately, so I'm closing this as superseded:

• The ThreadFork.execution.test.ts endedWatch assertion was fixed in test(server): a fork that stops its own PR watch keeps it as its ended watch #21309.
• The settings test mocks (components/ui paths and the DatabaseStorageNotice stub) were fixed in test(mobile): branch naming and server controls settings tests load again #21293.
• GrokAdapterV2.test.ts has a single effect/Path import, the mobile thread activity test already expects activity-group, and the two web tests that used react-test-renderer are no longer on main, so restoring that dependency isn't needed.

If main is still red for something this branch covered, reopen with the failing run and we'll take another look.