Skip to content

fix(server): drop stale text generation options when resetting text-gen model selection - #2076

Merged
juliusmarminge merged 6 commits into
pingdotgg:mainfrom
UtkarshUsername:fix/text-gen-model-reset-atomic-replace
Apr 16, 2026
Merged

fix(server): drop stale text generation options when resetting text-gen model selection#2076
juliusmarminge merged 6 commits into
pingdotgg:mainfrom
UtkarshUsername:fix/text-gen-model-reset-atomic-replace

fix(serverSettings): map SchemaError to ServerSettingsError in layerTest

7d14771
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Apr 16, 2026 in 20m 33s

Not eligible (click on check for details)

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This PR changes runtime behavior for how server settings patches are applied - switching from deep merge to conditional replace semantics for textGenerationModelSelection. While the change is well-tested and narrowly scoped, it modifies core settings logic affecting both server and client, and the author is not a frequent contributor to these files.

Notes:
No code owners found in target merge base 19d4740

View more details on MacroscopeApp