Skip to content

refactor(web): pull request markdown keeps its caching without "use memo" hooks #20744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

refactor(web): pull request markdown keeps its caching without "use memo" hooks #20744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions apps/web/src/components/pullRequest/PullRequestMarkdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,6 @@ export const PullRequestMarkdownContext = createContext<{
threadRef: ScopedThreadRef | null;
} | null>(null);

// Both asset hooks key on the resource's identity; the compiler cannot cache a value
// across successive hook calls in the component itself.
function useGitHubMediaResource(cwd: string, fetchUrl: string): AssetResource {
"use memo";
return { _tag: "github-media", cwd, url: fetchUrl };
}

function PullRequestGitHubVideo({
environmentId,
cwd,
Expand All @@ -36,7 +29,7 @@ function PullRequestGitHubVideo({
url: string;
fetchUrl: string;
}) {
const resource = useGitHubMediaResource(cwd, fetchUrl);
const resource: AssetResource = { _tag: "github-media", cwd, url: fetchUrl };
const assetUrl = useAssetUrlState(environmentId, resource);
const refreshAssetUrl = useAssetUrlRefresh(environmentId, resource);
const src =
Expand Down
Loading