Skip to content

refactor(web): paginated branches keep their caching without "use memo" #20743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

refactor(web): paginated branches keep their caching without "use memo" #20743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 15 additions & 36 deletions apps/web/src/state/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,21 @@ export function useThreadSearch(
};
}

// A hook so its result is frozen: `refresh` hands a page atom to the registry,
// which the compiler would treat as a mutation and leave pagesAtom uncached,
// resubscribing every render.
function useBranchPageAtoms(
environmentId: EnvironmentId | null,
cwd: string | null,
query: string,
cursors: ReadonlyArray<number | undefined>,
targetKey: string | null,
) {
// Calls no hooks, so the compiler needs the directive to memoize it.
"use memo";
export function usePaginatedBranches(target: VcsRefTarget) {
// Starts unkeyed: a key mismatch already resolves to the initial cursors, and seeding
// the key here would make every derivation below straddle this hook call.
const [pagination, setPagination] = useState<{
readonly targetKey: string | null;
readonly cursors: ReadonlyArray<number | undefined>;
}>({
targetKey: null,
cursors: INITIAL_BRANCH_CURSORS,
});
const { environmentId, cwd } = target;
const query = target.query?.trim() ?? "";
const targetKey =
environmentId !== null && cwd !== null ? JSON.stringify([environmentId, cwd, query]) : null;
const cursors = pagination.targetKey === targetKey ? pagination.cursors : INITIAL_BRANCH_CURSORS;
const pageAtoms =
environmentId !== null && cwd !== null
? cursors.map((cursor) =>
Expand All @@ -126,30 +129,6 @@ function useBranchPageAtoms(
const pagesAtom = Atom.make((get) => pageAtoms.map((atom) => get(atom))).pipe(
Atom.withLabel(`web:vcs-ref-pages:${targetKey ?? "empty"}`),
);
return { pageAtoms, pagesAtom };
}

export function usePaginatedBranches(target: VcsRefTarget) {
const query = target.query?.trim() ?? "";
const targetKey =
target.environmentId !== null && target.cwd !== null
? JSON.stringify([target.environmentId, target.cwd, query])
: null;
const [pagination, setPagination] = useState<{
readonly targetKey: string | null;
readonly cursors: ReadonlyArray<number | undefined>;
}>({
targetKey,
cursors: INITIAL_BRANCH_CURSORS,
});
const cursors = pagination.targetKey === targetKey ? pagination.cursors : INITIAL_BRANCH_CURSORS;
const { pageAtoms, pagesAtom } = useBranchPageAtoms(
target.environmentId,
target.cwd,
query,
cursors,
targetKey,
);
const results = useAtomValue(pagesAtom);
const values = results.flatMap((result) => {
const value = Option.getOrNull(AsyncResult.value(result));
Expand Down
Loading