Skip to content

perf(web): the sidebar chrome compiles without manual memoization #20684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

perf(web): the sidebar chrome compiles without manual memoization #20684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions apps/web/src/components/sidebar/SidebarChrome.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ArrowLeftIcon, ChartNoAxesColumnIcon, SettingsIcon } from "lucide-react";
import type { ReactNode } from "react";
import { memo, useCallback } from "react";
import { memo } from "react";
import { Link, useLocation, useNavigate } from "@tanstack/react-router";

import { useEnvironmentIdentificationMode } from "../../hooks/useSettings";
Expand Down Expand Up @@ -81,14 +81,11 @@ export function SidebarBrandWidthProbe({
}: {
onWidthChange: (width: number) => void;
}) {
const observeWidth = useCallback(
(probe: HTMLDivElement) => {
return observeResize(probe, ([entry]) => {
if (entry) onWidthChange(entry.borderBoxSize[0]?.inlineSize ?? probe.offsetWidth);
});
},
[onWidthChange],
);
const observeWidth = (probe: HTMLDivElement) => {
return observeResize(probe, ([entry]) => {
if (entry) onWidthChange(entry.borderBoxSize[0]?.inlineSize ?? probe.offsetWidth);
});
};

return (
<div
Expand Down Expand Up @@ -167,34 +164,34 @@ export const SidebarUtilityMenu = memo(function SidebarUtilityMenu() {
select: (location) => isSidebarUtilityPage(location.pathname),
});
const pullRequestsSupported = usePullRequestsSupported();
const closeMobileSidebar = useCallback(() => {
const closeMobileSidebar = () => {
if (isMobile) {
setOpenMobile(false);
}
}, [isMobile, setOpenMobile]);
const handlePullRequestsClick = useCallback(() => {
};
const handlePullRequestsClick = () => {
closeMobileSidebar();
void navigate({
to: "/pull-requests",
search: readPullRequestListPreferences(),
});
}, [closeMobileSidebar, navigate]);
const handleSettingsClick = useCallback(() => {
};
const handleSettingsClick = () => {
closeMobileSidebar();
void navigate({ to: "/settings" });
}, [closeMobileSidebar, navigate]);
};

const handleUsageClick = useCallback(() => {
const handleUsageClick = () => {
if (isMobile) {
setOpenMobile(false);
}
void navigate({ to: "/usage" });
}, [isMobile, navigate, setOpenMobile]);
};

const handleBackClick = useCallback(() => {
const handleBackClick = () => {
closeMobileSidebar();
void navigateToMainApp();
}, [closeMobileSidebar, navigateToMainApp]);
};

return (
<SidebarMenu className="flex-row items-center">
Expand Down
Loading