Skip to content

perf(web): the settings scope context compiles without manual memoization #20635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

perf(web): the settings scope context compiles without manual memoization #20635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 39 additions & 70 deletions apps/web/src/components/settings/SettingsScopeContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { parseT3ProjectFile } from "@t3tools/shared/t3ProjectFile";
import { useAtomValue } from "@effect/atom-react";
import * as Option from "effect/Option";
import { AsyncResult, Atom } from "effect/reactivity";
import { createContext, type ReactNode, useContext, useMemo } from "react";
import { createContext, type ReactNode, useContext } from "react";

import { useEnvironments, usePrimaryEnvironmentId } from "../../state/environments";
import { getProjectFileQueryAtom, optimisticFileAtom } from "../files/projectFilesQueryState";
Expand All @@ -15,79 +15,51 @@ import { selectSingleEnvironmentScope } from "./settingsScopeAxis";
function useMemberProjectFiles(scope: ReturnType<typeof resolveSettingsScope>) {
const members = scope.kind === "project" || scope.kind === "checkout" ? scope.members : [];
return useAtomValue(
useMemo(
() =>
Atom.make((get) => {
const files = new Map<string, T3ProjectFile | null>();
for (const member of members) {
const result = get(
getProjectFileQueryAtom(
member.environmentId,
member.workspaceRoot,
T3_PROJECT_FILE_NAME,
),
);
if (result.waiting) continue;
const data =
get(
optimisticFileAtom(
member.environmentId,
member.workspaceRoot,
T3_PROJECT_FILE_NAME,
),
)?.data ?? Option.getOrNull(AsyncResult.value(result));
files.set(
member.physicalProjectKey,
data === null || data.truncated ? null : parseT3ProjectFile(data.contents),
);
}
return files;
}),
[members],
),
Atom.make((get) => {
const files = new Map<string, T3ProjectFile | null>();
for (const member of members) {
const result = get(
getProjectFileQueryAtom(member.environmentId, member.workspaceRoot, T3_PROJECT_FILE_NAME),
);
if (result.waiting) continue;
const data =
get(optimisticFileAtom(member.environmentId, member.workspaceRoot, T3_PROJECT_FILE_NAME))
?.data ?? Option.getOrNull(AsyncResult.value(result));
files.set(
member.physicalProjectKey,
data === null || data.truncated ? null : parseT3ProjectFile(data.contents),
);
}
return files;
}),
);
}

function useResolvedSettingsScope(rawSearch: SettingsScopeSearch, singleEnvironment: boolean) {
const groups = useSettingsProjectGroups();
const { environments: availableEnvironments } = useEnvironments();
const primaryEnvironmentId = usePrimaryEnvironmentId();
const search = useMemo(
() =>
singleEnvironment
? selectSingleEnvironmentScope(
rawSearch,
resolveSettingsScope(rawSearch, groups, availableEnvironments),
availableEnvironments,
primaryEnvironmentId,
)
: rawSearch,
[availableEnvironments, groups, primaryEnvironmentId, rawSearch, singleEnvironment],
);
const scope = useMemo(
() => resolveSettingsScope(search, groups, availableEnvironments),
[availableEnvironments, groups, search],
);
const search = singleEnvironment
? selectSingleEnvironmentScope(
rawSearch,
resolveSettingsScope(rawSearch, groups, availableEnvironments),
availableEnvironments,
primaryEnvironmentId,
)
: rawSearch;
const scope = resolveSettingsScope(search, groups, availableEnvironments);
const projectFiles = useMemberProjectFiles(scope);
return useMemo(() => {
const selected = selectScopedSettingsEnvironments(
scope,
availableEnvironments,
primaryEnvironmentId,
);
const targets = resolveScopedSettingsTargets(
scope,
selected.connectedEnvironments,
projectFiles,
);
const target =
targets.find(
(candidate) => candidate.environmentId === selected.environment?.environmentId,
) ??
targets[0] ??
null;
return { scope, groups, search, ...selected, targets, target };
}, [availableEnvironments, groups, primaryEnvironmentId, projectFiles, scope, search]);
const selected = selectScopedSettingsEnvironments(
scope,
availableEnvironments,
primaryEnvironmentId,
);
const targets = resolveScopedSettingsTargets(scope, selected.connectedEnvironments, projectFiles);
const target =
targets.find((candidate) => candidate.environmentId === selected.environment?.environmentId) ??
targets[0] ??
null;
return { scope, groups, search, ...selected, targets, target };
}

const SettingsScopeContext = createContext<
Expand All @@ -111,10 +83,7 @@ export function SettingsScopeProvider({
children: ReactNode;
}) {
const resolved = useResolvedSettingsScope(search, singleEnvironment);
const value = useMemo(
() => ({ ...resolved, singleEnvironment, selectScope: onChange }),
[onChange, resolved, singleEnvironment],
);
const value = { ...resolved, singleEnvironment, selectScope: onChange };
return <SettingsScopeContext value={value}>{children}</SettingsScopeContext>;
}

Expand Down
Loading