Skip to content

perf(web): the provider update pill compiles with the React Compiler #20590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

perf(web): the provider update pill compiles with the React Compiler #20590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 25 additions & 32 deletions apps/web/src/components/sidebar/SidebarProviderUpdatePill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useNavigate } from "@tanstack/react-router";
import { useAtomValue } from "@effect/atom-react";
import type { ServerProvider } from "@t3tools/contracts";
import { CircleCheckIcon, DownloadIcon, TriangleAlertIcon, XIcon } from "lucide-react";
import { useCallback, useEffect, useState, type CSSProperties } from "react";
import { useEffect, useEffectEvent, useState, type CSSProperties } from "react";

import { primaryServerProvidersAtom } from "../../state/server";
import {
Expand Down Expand Up @@ -56,15 +56,13 @@ export function SidebarProviderUpdatePill() {
dismissedKeys,
});

useEffect(() => {
if (visibleAfterIso === undefined && effectiveVisibleAfterIso !== undefined) {
setVisibleAfterIso(effectiveVisibleAfterIso);
}
}, [effectiveVisibleAfterIso, visibleAfterIso]);
if (visibleAfterIso === undefined && effectiveVisibleAfterIso !== undefined) {
setVisibleAfterIso(effectiveVisibleAfterIso);
}

const openProviderSettings = useCallback(() => {
const openProviderSettings = () => {
void navigate({ to: "/settings/providers" });
}, [navigate]);
};
const displayedView = renderedView ?? view;
const dismissAfterVisibleMs = displayedView?.dismissAfterVisibleMs;
const viewKey = displayedView?.key ?? null;
Expand All @@ -73,37 +71,32 @@ export function SidebarProviderUpdatePill() {
displayedView?.tone !== "loading" &&
exitingKey !== viewKey;

const startExit = useCallback(
(key: string, nextView: ProviderUpdateSidebarPillView | null, dismissKey?: string) => {
if (exitingKey === key) {
return;
}
setPendingView(nextView);
setExitingKey(key);
setDismissAfterExitKey(dismissKey ?? null);
},
[exitingKey],
);

useEffect(() => {
if (exitingKey !== null) {
const startExit = (
key: string,
nextView: ProviderUpdateSidebarPillView | null,
dismissKey?: string,
) => {
if (exitingKey === key) {
return;
}
setPendingView(nextView);
setExitingKey(key);
setDismissAfterExitKey(dismissKey ?? null);
};

if (exitingKey === null) {
if (!renderedView) {
if (view) {
setRenderedView(view);
}
return;
}
if (!view) {
} else if (!view) {
startExit(renderedView.key, null);
return;
}
if (view.key !== renderedView.key) {
} else if (view.key !== renderedView.key) {
startExit(renderedView.key, view);
return;
}
}, [exitingKey, renderedView, startExit, view]);
}

const exitAfterVisible = useEffectEvent((key: string) => startExit(key, null, key));

useEffect(() => {
if (!dismissAfterVisibleMs || !viewKey) {
Expand All @@ -113,11 +106,11 @@ export function SidebarProviderUpdatePill() {
return;
}
const timeoutId = window.setTimeout(() => {
startExit(viewKey, null, viewKey);
exitAfterVisible(viewKey);
}, dismissAfterVisibleMs);

return () => window.clearTimeout(timeoutId);
}, [dismissAfterVisibleMs, exitingKey, startExit, viewKey]);
}, [dismissAfterVisibleMs, exitingKey, viewKey]);

if (!displayedView) {
return null;
Expand Down
Loading