Skip to content

fix(web): Antigravity setup card separators match other settings cards #20088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 4 commits into from
Oct 18, 2026
Merged

fix(web): Antigravity setup card separators match other settings cards #20088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0ff021
fix(web): Antigravity setup card separators match other settings cards
MONKE2525E Oct 16, 2026
139eb79
Merge branch 'main' into fix/antigravity-setup-card-separators
MONKE2525E Oct 16, 2026
08b96e9
Merge branch 'main' into fix/antigravity-setup-card-separators
MONKE2525E Oct 16, 2026
3b29df9
Merge branch 'main' into fix/antigravity-setup-card-separators
MONKE2525E Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions apps/web/src/components/settings/ProviderInstanceCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,26 +1184,24 @@ export function ProviderInstanceCard({
{setup || environmentFields.length > 0 ? (
<SettingsSection title="Setup">
{setup}
<div
inert={readOnly}
aria-disabled={readOnly || undefined}
className={readOnly ? "opacity-50 select-none" : undefined}
>
{environmentFields.length > 0 ? (
<>
{environmentFields.map((field) => (
<ProviderEnvironmentFieldRow
key={field.name}
field={field}
variable={readProviderEnvironmentVariable(instance.environment, field.name)}
idPrefix={`provider-instance-${instanceId}`}
onCommit={updateEnvironmentField}
onRemove={removeEnvironmentField}
/>
))}
</>
) : null}
</div>
{environmentFields.length > 0 ? (
<div
inert={readOnly}
aria-disabled={readOnly || undefined}
className={readOnly ? "opacity-50 select-none" : undefined}
>
{environmentFields.map((field) => (
<ProviderEnvironmentFieldRow
key={field.name}
field={field}
variable={readProviderEnvironmentVariable(instance.environment, field.name)}
idPrefix={`provider-instance-${instanceId}`}
onCommit={updateEnvironmentField}
onRemove={removeEnvironmentField}
/>
))}
</div>
) : null}
</SettingsSection>
) : null}

Expand Down
9 changes: 5 additions & 4 deletions apps/web/src/components/settings/ProviderSetupSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function ProviderSetupSection(props: ProviderSetupSectionProps) {
return (
<section
aria-label="Antigravity setup"
className="@container/setup divide-y divide-border/50 text-xs"
className="@container/setup divide-y divide-border/50 text-xs [&_[data-slot=settings-row]]:rounded-none"
>
<SettingsRow
className="@max-lg/setup:[&>div:first-child]:flex @max-lg/setup:[&>div:first-child]:items-stretch @max-lg/setup:[&>div:first-child]:gap-3"
Expand Down Expand Up @@ -185,6 +185,10 @@ function ProviderSetupActions({

return (
<div className="divide-y divide-border/50">
{/* Keep the live region first so the last visible row is not followed by a sibling that adds its divider. */}
<p className="sr-only" role="status">
{pendingLabel ? `${pendingLabel}.` : null}
</p>
<SettingsRow
title="Runtime"
className="@max-lg/setup:[&>div:first-child]:flex @max-lg/setup:[&>div:first-child]:items-stretch @max-lg/setup:[&>div:first-child]:gap-3"
Expand Down Expand Up @@ -298,9 +302,6 @@ function ProviderSetupActions({
readOnly={false}
/>

<p className="sr-only" role="status">
{pendingLabel ? `${pendingLabel}.` : null}
</p>
{error || queryError ? (
<div className="grid gap-2 px-3 py-3 sm:px-4">
<p role="alert" className="text-destructive [overflow-wrap:anywhere]">
Expand Down
Loading