Repository navigation
Use latest user message time for thread timestamps #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+165
−555
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0bb7044
Use latest user message time for thread timestamps
juliusmarminge 0e8c1fe
Stabilize sidebar thread timestamp updates
juliusmarminge a812f36
Format sidebar thread timestamps consistently
juliusmarminge 1825bef
Remove react-scan from web shell
juliusmarminge 7749745
Consolidate thread registration across stream updates
juliusmarminge c26d203
kewl
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidebar summary never written for full thread updates
High Severity
The
writeThreadStatefunction no longer writes tosidebarThreadSummaryById, but it's the sole write path for many thread events. When athread.createdevent fires, the thread ID is added tothreadIdsand other structures, but nosidebarThreadSummaryByIdentry is created. SinceselectSidebarThreadsForProjectReffilters out threads without a sidebar summary entry, newly created threads won't appear in the sidebar until a separatethread-upsertedshell event arrives. Similarly, all event-driven updates (thread.message-sent,thread.archived,session-set, etc.) viaupdateThreadState→writeThreadStatewon't update the sidebar'slatestUserMessageAt,hasPendingApprovals, or other derived fields — the very fields this PR aims to leverage.Additional Locations (1)
apps/web/src/store.ts#L1382-L1383Reviewed by Cursor Bugbot for commit 0bb7044. Configure here.