Skip to content

fix(web): PR checks scrollbar no longer covers Details - #19404

Merged
juliusmarminge merged 6 commits into
pingdotgg:mainfrom
psv2522:fix/pr-checks-popover-scrollbar
Oct 20, 2026
Merged

juliusmarminge merged 6 commits into
pingdotgg:mainfrom
psv2522:fix/pr-checks-popover-scrollbar

Conversation

@psv2522

@psv2522 psv2522 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

When a PR has enough checks to overflow its popover, the overlay scrollbar covers the right-aligned Details links. Extend the scroll area 12px into the existing popover padding and give that space back as list padding. The rows keep their original alignment while the 6px scrollbar moves into the gutter.

Maintainer takeover of #19404, with credit to @psv2522. The independent implementation pass retained the original two-line fix. Contributor commits are preserved and main was merged.

One parallel adversarial review round (Claude Opus and Codex Sol) found no confirmed actionable code issue. Human approval remains outstanding; this PR is unmerged.

Verification:

  • 155 → 155 existing tests across three unchanged suites: checks presentation, grouping and detail logic. No CSS-string or static-layout tests added.
  • Targeted lint, formatting, web typecheck and diff checks pass. Lint has one unchanged array-index-key warning.
  • Actual Linux web client, 28 safe fixture checks injected through the existing detail cache. At 1280×800, the Details edge stays at x=1158.28: main's track occupies x=1151.28–1157.28; this head moves it to x=1163.28–1169.28, leaving a 5px gap. Matching screenshots use actual main and head with the same state.
  • Show all → scroll to check 28 → Show less preserves Details alignment. Hit testing confirms the final Details button is unobstructed. At 600×700, the popup fits and the scroll viewport has no horizontal overflow.
  • Source inspection confirms the lazy listing trigger, detail header and thread-details count trigger share ChecksBody. Integrated proof covers the detail-header path. Native mobile has separate rows. GitHub fetching, external check-page navigation, the other trigger paths, RTL, macOS, Windows, Electron desktop, iOS, Android and relay/tunnel connections were not exercised.

Before — actual main:

Before: overlay scrollbar covers Details

After — PR head, same viewport and fixture:

After: scrollbar sits beside Details in the gutter

Expand, scroll to the final check, and collapse:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d3eac2a9a577c837/mcp-launch-client-3a65bc2764-e023-4047-9b26-6cb8bf7587b1-fwd-3a60025522c9731b64a-b18c7f78-c5f4-4abb-bac2-e23550f383d2-mp4.mp4

Models and harness: Codex gpt-6-astra for tests, Codex gpt-6.1-sol for implementation and integration, Claude claude-opus-5-5 and Codex gpt-6-sol for independent reviews, through T3 Code.

Overlay scrollbar takes no layout space. List borrows popover's
inline padding for the scrollbar lane, so rows stay aligned with
the header and nothing shifts when the list starts to overflow.
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 14, 2026
@psv2522
psv2522 marked this pull request as ready for review October 14, 2026 11:51
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7ed3c699-75d0-4254-bc18-b6d5304a27d5
📥 Commits

Reviewing files that changed from the base of the PR and between 0f45aa3 and 4272db6.

📒 Files selected for processing: 1
  • apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 762521de-181b-471a-8e45-a197097e0311
📥 Commits

Reviewing files that changed from the base of the PR and between ca569c3 and 0f45aa3.

📒 Files selected for processing: 1
  • apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx
🚧 Files skipped from review as they are similar to previous changes: 1
  • apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The checks popover scroll area gains a negative end margin. Its list gains matching end padding. Check rendering and popover behavior remain unchanged.

Changes: Checks popover spacing

Layer / File(s) Summary
Scroll area end spacing
apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx
The scroll area gains a negative end margin, and its list gains matching end padding.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0f45a

No actionable merge risk remains beyond normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title is concise, uses the conventional commit format, and clearly describes the scrollbar fix that prevents it from covering Details links.
Description check Passed The description covers the problem, implementation, approval context, verification results, screenshots, recording, limitations, and tool attribution. It provides sufficient detail for review.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Resolve the single conflict in PullRequestChecksPopover.tsx. Main
pruned comments there (pingdotgg#19559) in the same block this branch fixes
for the checks scrollbar. Keep the scrollbar classes and main's
pruned JSX.

Refs pingdotgg#19404
@juliusmarminge juliusmarminge self-assigned this Oct 19, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Taking over this one as maintainer for batch pull-request-01. I’ll keep the focused checks-popover fix on the original PR, verify the scrollbar and Details-link spacing in the running Linux client, and run independent reviews. No merge in this pass.

…-scrollbar

# Conflicts:
#	apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx
@juliusmarminge
juliusmarminge merged commit 4583cad into pingdotgg:main Oct 20, 2026
42 of 44 checks passed
Pipyakas pushed a commit to Pipyakas/t3code that referenced this pull request Oct 21, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 4583cad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants