Repository navigation
fix(web): PR checks scrollbar no longer covers Details - #19404
Conversation
Overlay scrollbar takes no layout space. List borrows popover's inline padding for the scrollbar lane, so rows stay aligned with the header and nothing shifts when the list starts to overflow.
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 6 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Resolve the single conflict in PullRequestChecksPopover.tsx. Main pruned comments there (pingdotgg#19559) in the same block this branch fixes for the checks scrollbar. Keep the scrollbar classes and main's pruned JSX. Refs pingdotgg#19404
|
Taking over this one as maintainer for batch pull-request-01. I’ll keep the focused checks-popover fix on the original PR, verify the scrollbar and Details-link spacing in the running Linux client, and run independent reviews. No merge in this pass. |
…-scrollbar # Conflicts: # apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx
Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit 4583cad)
When a PR has enough checks to overflow its popover, the overlay scrollbar covers the right-aligned Details links. Extend the scroll area 12px into the existing popover padding and give that space back as list padding. The rows keep their original alignment while the 6px scrollbar moves into the gutter.
Maintainer takeover of #19404, with credit to @psv2522. The independent implementation pass retained the original two-line fix. Contributor commits are preserved and main was merged.
One parallel adversarial review round (Claude Opus and Codex Sol) found no confirmed actionable code issue. Human approval remains outstanding; this PR is unmerged.
Verification:
Before — actual main:
After — PR head, same viewport and fixture:
Expand, scroll to the final check, and collapse:
https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d3eac2a9a577c837/mcp-launch-client-3a65bc2764-e023-4047-9b26-6cb8bf7587b1-fwd-3a60025522c9731b64a-b18c7f78-c5f4-4abb-bac2-e23550f383d2-mp4.mp4
Models and harness: Codex gpt-6-astra for tests, Codex gpt-6.1-sol for implementation and integration, Claude claude-opus-5-5 and Codex gpt-6-sol for independent reviews, through T3 Code.