Skip to content

fix(shared): detect *.ghe.com remotes as GitHub #19362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 18, 2026
+18 −1
Merged

fix(shared): detect *.ghe.com remotes as GitHub #19362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/shared/src/sourceControl.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,22 @@ describe("detectSourceControlProviderFromRemoteUrl", () => {
).toBe("bitbucket");
});

it("detects GitHub Enterprise Cloud data residency hosts on ghe.com", () => {
expect(detectSourceControlProviderFromRemoteUrl("https://acme.ghe.com/owner/repo.git")).toEqual(
{
kind: "github",
name: "GitHub Self-Hosted",
baseUrl: "https://acme.ghe.com",
},
);
expect(detectSourceControlProviderFromRemoteUrl("git@acme.ghe.com:owner/repo.git")?.kind).toBe(
"github",
);
expect(detectSourceControlProviderFromRemoteUrl("https://ghe.com/owner/repo.git")?.kind).toBe(
"unknown",
);
});

it("does not match provider names embedded in unrelated DNS labels", () => {
expect(
detectSourceControlProviderFromRemoteUrl("https://notgithub.example.com/owner/repo.git")
Expand Down
3 changes: 2 additions & 1 deletion packages/shared/src/sourceControl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,9 @@ function hasDnsLabel(host: string, label: string): boolean {
return host.split(".").includes(label);
}

/** `*.ghe.com` is GitHub Enterprise Cloud with data residency, one subdomain per enterprise. */
function isGitHubHost(host: string): boolean {
return host === "github.com" || hasDnsLabel(host, "github");
return host === "github.com" || host.endsWith(".ghe.com") || hasDnsLabel(host, "github");
}

function isGitLabHost(host: string): boolean {
Expand Down
Loading