Skip to content

fix(desktop): local desktop builds no longer crash when a GitHub token is in the shell #19277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 18, 2026
Merged

fix(desktop): local desktop builds no longer crash when a GitHub token is in the shell #19277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions scripts/build-desktop-artifact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
undefined,
);

assert.notProperty(preview, "publish");
assert.notProperty(previewChannel, "publish");
assert.isNull(preview.publish);
assert.isNull(previewChannel.publish);
assert.deepStrictEqual(release.publish, [
{
provider: "github",
Expand All @@ -382,6 +382,22 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
),
);

it.effect("disables electron-builder publish detection for local builds", () =>
Effect.gen(function* () {
const local = yield* createBuildConfig(
"mac",
"dmg",
"0.0.33",
false,
false,
undefined,
undefined,
);

assert.isNull(local.publish);
}).pipe(Effect.provide(ConfigProvider.layer(ConfigProvider.fromEnv({ env: {} })))),
);

it("stages only the desktop main-process externals", () => {
assert.deepStrictEqual(
resolveDesktopRuntimeDependencies(
Expand Down
4 changes: 4 additions & 0 deletions scripts/build-desktop-artifact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2722,6 +2722,10 @@ export const createBuildConfig = Effect.fn("createBuildConfig")(function* (
],
};
const updateChannel = resolveDesktopUpdateChannel(version);
// A missing `publish` makes electron-builder infer a GitHub feed from
// GH_TOKEN/GITHUB_TOKEN. The staged app has no repository to resolve it
// against, so writing update manifests then crashes on a null config.
buildConfig.publish = null;
if (!isDesktopPreviewVersion(version)) {
const publishConfig = yield* resolveGitHubPublishConfig(updateChannel);
if (publishConfig) {
Expand Down
Loading