Repository navigation
fix(clients): copy filesystem paths with native separators - #19201
tonyjosephsebastians wants to merge 4 commits into
Conversation
Copy Markdown file-link paths with native separators for Windows drive and UNC targets, including relative path copies. Use the target path to choose separators so remote POSIX workspaces keep their original clipboard paths. Fixes pingdotgg#19142 Verified with 156 focused tests, the web typecheck, formatting, and scoped lint. Lint reports only pre-existing warnings outside the changed code.
github-actions
Bot
added
vouch:unvouched
…ream pingdotgg#19201) Own diff of pingdotgg#19201 at 1173de5 against its merge base. ChatMarkdown.test.tsx: 82 passed before, 98 after; tsc clean in apps/web. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@juliusmarminge, this PR fixes the Windows file-path clipboard issue in #19142. I found your recent work on Markdown file links and previews, so I thought you would be a suitable reviewer. The original handler reproduced four failing clipboard cases. The fix passes 156 focused tests covering Windows drive paths, UNC shares, spaces, relative paths, and POSIX remote workspaces, plus the web typecheck. Scoped lint reports only existing warnings. Native Windows Open-dialog verification and before/after UI screenshots remain pending: the built-in Browser was unavailable for verification. These limitations are recorded in the PR description. Could you review it or direct it to the appropriate reviewer when you have capacity? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1173de5039
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Issue #19142 requires native Windows separators for copied full and relative Markdown file-link paths. ChatMarkdown.tsx now formats both clipboard values with formatFilePathForClipboard. The forma… |
| Out of Scope Changes check | |
The production changes apply the same clipboard-boundary formatting to related filesystem-path copy actions in web, mobile, media menus, workspace actions, and file previews. Tests support these chang… |
| Title check | |
The title clearly and concisely describes the main change: copying filesystem paths with native separators. |
| Description check | |
The description explains the problem, implementation, scope exception, focused verification, and remaining verification limits. It uses alternate headings such as Summary and Tests done, but it provid… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Move clipboard path formatting into shared client logic and use it for web, desktop, and mobile chat file menus. Add mobile-menu and shared formatter regression coverage for Windows drive and UNC paths, POSIX hosts, and unknown workspace roots.
github-actions
Bot
added
size:M
|
"@codex review". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3abf50b8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| /** Format clipboard text using the file's host path, which can differ from the client's OS. */ | ||
| export function formatFilePathForClipboard(path: string, hostPath = path): string { | ||
| return isWindowsAbsolutePath(hostPath) ? path.replaceAll("/", "\\") : path; |
There was a problem hiding this comment.
On a Windows-hosted Markdown image or video (for example an authored C:/repo/shot.png), the right-click/long-press media menus still bypass this formatter: apps/web/src/components/media/MediaActions.tsx:165-174 and apps/mobile/src/state/mediaActions.ts:109-120 send reference.path/relativePath directly to the clipboard, while classifyMarkdownImageSource preserves that forward-slash drive path. Consequently the file-chip menu is fixed but the same Copy full/relative path actions on chat media still copy non-native separators on both clients; route those payloads through this helper as well.
AGENTS.md reference: AGENTS.md:L67-L70
Useful? React with 👍 / 👎.
Use shared host-path formatting for web and mobile media menus, workspace-header copies, and file-preview copies. Preserve URL payloads and refresh memoized mobile menu actions when the workspace directory changes. Add image, video, drive-path, UNC, and workspace-menu regression coverage.
github-actions
Bot
added
size:L
tonyjosephsebastians
changed the title
This branch has not been deployed
1 participant
Summary
Fixes #19142.
Filesystem-path copy actions can put forward-slash Windows paths on the clipboard, such as
C:/Users/me/project/reports/Device Users.csv, instead ofC:\Users\me\project\reports\Device Users.csv.Use the shared
formatFilePathForClipboardhelper to select separators from the target environment. This covers web/desktop and mobile chat file menus, image/video media menus, workspace-header copies, and file-preview copies. POSIX paths retain their style when accessed from a Windows client. Copy feedback shows the clipboard value.Formatting happens at clipboard writes. File opening, sharing, downloading, and filesystem permissions use their existing paths and behavior. URL, content, and composer-reference copy actions retain their intended representations. Mobile file-preview menu dependencies include the workspace directory so retained actions update when it changes.
Scope and approval
This addresses one underlying separator defect across existing filesystem-path copy actions. The shared formatter is small and reuses the existing Windows-path detector; client changes apply it at their clipboard boundaries.
The change falls under the focused obvious-bug exception in CONTRIBUTING.md. No maintainer approval is claimed.
Tests done
Verified locally on Windows with Node 24, Vite+, and the updated pinned typechecker:
vp test run apps/web/src/components/ChatMarkdown.test.tsx apps/web/src/markdown-links.test.ts apps/web/src/filePathDisplay.test.ts packages/shared/src/fileLinks.test.ts apps/mobile/src/features/threads/fileChipMenu.test.ts packages/client-runtime/src/mediaActions.test.ts apps/web/src/components/BranchToolbar.panel.test.tsx apps/web/src/components/BranchToolbar.logic.test.ts apps/web/src/components/ChatView.logic.test.ts apps/web/src/components/media/MediaActions.test.tsx apps/mobile/src/lib/mediaActions.test.ts packages/client-runtime/src/mediaReference.test.ts packages/client-runtime/src/markdownImages.test.ts --pool=threads --maxWorkers=1vp run --filter @t3tools/web typecheckandvp run --filter @t3tools/client-runtime typecheck. Shared-client checking reports existing informational Effect suggestions.Remaining verification