Skip to content

fix(provider-acp): track terminal output byte length to avoid per-chunk re-encode (#19052) - #19115

Closed
ghost wants to merge 3 commits into
mainfrom
unknown repository
Closed

fix(provider-acp): track terminal output byte length to avoid per-chunk re-encode (#19052)#19115
ghost wants to merge 3 commits into
mainfrom
unknown repository

repro(#19052): neutralize collector header names to bench-*

babacd2
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check completed Oct 13, 2026 in 1m 43s

2 issues identified (3 code objects reviewed).

• Merge Base: 98a6246
• Head: babacd2

Details

✅ File Path U3 Bytes Comments Posted Reason
❌ repro/reproduce-19052.mjs 13047 2
➖ packages/provider-acp/src/server/runtimeModel.test.ts 1639 Excluded by macroscope ignore file
✅ packages/provider-acp/src/server/runtimeModel.ts 3625 0

Billed Total: 16.67KB of diff | $0.67

Filtered Issues Details

repro/reproduce-19052.mjs
  • line 315: The live leg never measures or verifies terminal throughput: its only terminal.write sends the small Python snapshot script, then it logs success and destroys the socket without reading any RPC response, waiting for completion, or checking MARKER. Thus even a rejected terminal.open/terminal.write produces the 'payload streamed' message, and no benchmark-sized log or timing result exercises the accumulation fix. Await successful RPC responses and stream/measure actual benchmark output rather than treating a socket write as verification. [ Out of scope (post-validation triage) ]
View more details on MacroscopeApp