Skip to content

fix(server): show Cursor run errors instead of "Provider turn failed." #18699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shoham-utila wants to merge 2 commits into from
Closed

fix(server): show Cursor run errors instead of "Provider turn failed." #18699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f7baa
fix(server): show Cursor run errors instead of "Provider turn failed."
shoham-utila Oct 12, 2026
79c6eaf
revert(server): keep Cursor text generation out of this fix
shoham-utila Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/server/src/orchestration-v2/Adapters/CursorAdapterV2.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ describe("CursorAdapterV2", () => {
status,
model: { id: "composer-2.5" },
durationMs: 1,
...(status === "error"
? { error: { message: 'AI Model Not Found: "grok-4.7"' } }
: {}),
}),
cancel: Effect.void,
};
Expand Down Expand Up @@ -185,6 +188,11 @@ describe("CursorAdapterV2", () => {
status === "finished" ? "idle" : status === "cancelled" ? "cancelled" : "failed",
);
assert.isNotNull(rows.at(-1)?.subagent.completedAt);
const terminal = events.findLast((event) => event.type === "turn.terminal");
assert.equal(
terminal?.type === "turn.terminal" ? terminal.failure?.message : undefined,
status === "error" ? 'AI Model Not Found: "grok-4.7"' : undefined,
);
}).pipe(Effect.scoped, Effect.provide(Layer.merge(NodeServices.layer, IdAllocator.layer))),
);

Expand Down
19 changes: 11 additions & 8 deletions apps/server/src/orchestration-v2/Adapters/CursorAdapterV2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2298,14 +2298,17 @@ export function makeCursorAdapterV2(
status,
...(status === "failed"
? {
failure: makeProviderFailure({
cause:
transportFailure ?? (result as { readonly error?: unknown }).error,
class:
transportFailure === undefined
? "provider_error"
: "transport_error",
}),
failure:
transportFailure === undefined
? makeProviderFailure({
message: result.error?.message,
code: result.error?.code,
class: "provider_error",
})
: makeProviderFailure({
cause: transportFailure,
class: "transport_error",
}),
}
: {}),
});
Expand Down
4 changes: 3 additions & 1 deletion apps/server/src/textGeneration/CursorTextGeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ function cursorSdkResultDetail(result: RunResult): string {
case "cancelled":
return "Cursor SDK request was cancelled.";
case "error":
return "Cursor SDK request finished with an error.";
return result.error?.message
? `Cursor SDK request failed: ${result.error.message}`
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
: "Cursor SDK request finished with an error.";
case "finished":
return "Cursor SDK returned empty output.";
}
Expand Down
Loading