Repository navigation
fix(mobile): preserve browser prompt replies across control updates #18419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maria-rcks
merged 1 commit into
pingdotgg:main
from
saphid:t3code/sweep/mobile-prompt-reply
Oct 12, 2026
+65
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
apps/mobile/src/features/browser/previewPromptText.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
|
|
||
| import { previewPromptText } from "./previewPromptText"; | ||
|
|
||
| describe("browser prompt response", () => { | ||
| const prompt = { type: "prompt" as const, message: "Your name?", defaultValue: "Guest" }; | ||
|
|
||
| it("preserves a typed response across repeated control broadcasts", () => { | ||
| expect(previewPromptText(prompt, { ...prompt }, "Alice")).toBe("Alice"); | ||
| }); | ||
|
|
||
| it("preserves an intentionally empty response", () => { | ||
| expect(previewPromptText(prompt, { ...prompt }, "")).toBe(""); | ||
| }); | ||
|
|
||
| it("initializes a newly opened prompt", () => { | ||
| expect(previewPromptText(null, prompt, "")).toBe("Guest"); | ||
| }); | ||
|
|
||
| it("resets a stale draft after reconnecting without dialog history", () => { | ||
| expect(previewPromptText(null, prompt, "Alice")).toBe("Guest"); | ||
| }); | ||
|
|
||
| it("resets when the message changes", () => { | ||
| expect(previewPromptText(prompt, { ...prompt, message: "Next name?" }, "Alice")).toBe("Guest"); | ||
| }); | ||
|
|
||
| it("resets when the default value changes", () => { | ||
| expect(previewPromptText(prompt, { ...prompt, defaultValue: "Bob" }, "Alice")).toBe("Bob"); | ||
| }); | ||
|
|
||
| it("resets when the dialog type changes with matching message and default", () => { | ||
| expect(previewPromptText(prompt, { ...prompt, type: "confirm" }, "Alice")).toBe("Guest"); | ||
| }); | ||
|
|
||
| it("clears a closed dialog and initializes an identical reopened prompt", () => { | ||
| const cleared = previewPromptText(prompt, null, "Alice"); | ||
| expect(cleared).toBe(""); | ||
| expect(previewPromptText(null, prompt, cleared)).toBe("Guest"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import type { PreviewStreamControl } from "@t3tools/client-runtime/preview/server-browser-stream"; | ||
|
|
||
| type Dialog = PreviewStreamControl["dialog"]; | ||
|
|
||
| /** Updates the native response draft when a browser control message arrives. */ | ||
| export function previewPromptText(previous: Dialog, next: Dialog, draft: string) { | ||
| if ( | ||
| next?.type !== previous?.type || | ||
| next?.message !== previous?.message || | ||
| next?.defaultValue !== previous?.defaultValue | ||
| ) { | ||
| return next?.defaultValue ?? ""; | ||
| } | ||
| return draft; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.