Repository navigation
feat(source-control): each host package ships a client definition - #17746
Merged
Merged
MacroscopeApp / Macroscope - Correctness Check
succeeded
Oct 10, 2026 in 45s
No issues identified (7 code objects reviewed).
• Merge Base:
ed22e11
• Head:b2b4f0f
Details
| ✅ | File Path | U3 Bytes | Comments Posted | Reason |
|---|---|---|---|---|
| ➖ | pnpm-lock.yaml |
1098 | Excluded by macroscope ignore file | |
| ✅ | packages/client-runtime/src/sourceControlClients.ts |
1904 | ||
| ✅ | packages/source-control-github/src/client/definition.ts |
1250 | 0 | |
| ✅ | packages/source-control-gitlab/src/client/definition.ts |
1122 | 0 | |
| ➖ | packages/client-runtime/src/sourceControlClients.test.ts |
839 | Excluded by macroscope ignore file | |
| ✅ | packages/source-control-core/src/client/definition.ts |
7928 | 0 | |
| ✅ | packages/source-control-forgejo/src/client/definition.ts |
2314 | 0 | |
| ✅ | packages/source-control-gitcafe/src/client/definition.ts |
1628 | 0 | |
| ✅ | packages/source-control-bitbucket/src/client/definition.ts |
1649 | 0 | |
| ✅ | packages/source-control-azure-devops/src/client/definition.ts |
1413 | 0 | |
| ➖ | packages/source-control-core/package.json |
330 | Excluded by macroscope ignore file | |
| ➖ | packages/client-runtime/package.json |
829 | Excluded by macroscope ignore file | |
| ➖ | packages/source-control-github/package.json |
297 | Excluded by macroscope ignore file | |
| ➖ | packages/source-control-gitlab/package.json |
297 | Excluded by macroscope ignore file | |
| ➖ | packages/source-control-forgejo/package.json |
297 | Excluded by macroscope ignore file | |
| ➖ | packages/source-control-gitcafe/package.json |
297 | Excluded by macroscope ignore file | |
| ➖ | packages/source-control-bitbucket/package.json |
315 | Excluded by macroscope ignore file | |
| ➖ | packages/source-control-azure-devops/package.json |
321 | Excluded by macroscope ignore file |
Billed Total: 17.30KB of diff | $0.69
Filtered Issues Details
packages/source-control-core/src/client/definition.ts
- line 90:
isChangeRequestPathchecks only the first occurrence ofroute, so a repository path containing the route name prevents valid change request URLs from being recognized. For example, GitHub's ownchangeRequestUrl({host: "github.com", repository: "pull/demo", number: 42})produceshttps://github.com/pull/demo/pull/42, but this helper testsdemo/pull/42after the first/pull/and returns false. The registry consequently fails to attribute the URL and returns "the host" instead of GitHub. Search for a route occurrence followed by a number rather than stopping at the first substring match. [ Already posted ]
Loading