Repository navigation
fix(server): clear snooze when settling threads - #17547
All clear
All clear
Details
Warning
- Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 1 changed files (no prior completed review)
🔍 Agent activity — 13 tool calls
1. browse_code — apps/server/src/orchestration-v2/Orchestrator.ts
2. browse_code — apps/server/src/orchestration-v2/Orchestrator.control-reads.test.ts
3. browse_code — Find focused tests for explicit thread.settle on snoozed threads in apps/server/src/orchestration-v2/Orchestrator.control-reads.test.ts at current head; summarize assertions and whether external services use test layers rather than mocks of core business logic.
4. browse_code — apps/server/src/orchestration-v2/Orchestrator.control-reads.test.ts
5. browse_code — In Orchestrator.ts current head, identify service context surrounding thread.settle changed lines 2892-2897: is this logic within a service method or transport handler/free exported function? Brief answer.
6. browse_code — Find contents of .macroscope check configuration for Effect Service Conventions if available, and compare modified lines of Orchestrator.ts with docs/internals/effect-services.md only for convention violations. Reply concisely.
7. browse_code — Does Orchestrator.ts current head introduce new imports/service dependencies or error types specifically in thread.settle branch around 2892? Answer based on file only.
8. browse_code — Briefly verify thread.settle mutation in Orchestrator.ts uses existing service dispatch and no new runtime boundary, imports, tagged errors or lint directives in lines 2892-2897.
9. browse_code — Is test 'explicit settle clears snooze atomically and stays idempotent after re-snoozing' a focused test with real Orchestrator service and in-memory external services? Respond yes/no.
10. browse_code — Does current thread.settle code in Orchestrator.ts require code convention change under service placement or imports? Answer concise.
11. browse_code — Summarize precise changed lines 2892-2897 in Orchestrator.ts at head.
12. browse_code — Confirm no new lint directives within Orchestrator.ts lines 2892-2897. Answer yes/no.
13. browse_code — Are lines 2892-2897 pure state updates and not Effect dependency injection? answer brief.
Agent Credits: 107 credits
Token usage: 264 uncached input · 1,843,166 cache-read input · 226,609 cache-write input · 7,362 output
Agent Credits may also include non-token charges from external tools such as web research.