Skip to content

fix(server): preserve Codex sign-in guidance in usage notices #17055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 4 commits into from
Oct 23, 2026
Merged

fix(server): preserve Codex sign-in guidance in usage notices #17055

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2917be2
fix(server): preserve Codex sign-in guidance in usage notices
jieyuexing Oct 8, 2026
d34481c
Merge remote-tracking branch 'origin/main' into takeover/17055
juliusmarminge Oct 18, 2026
f67ed3f
test(server): focus Codex usage auth regression
juliusmarminge Oct 18, 2026
dd20869
chore: merge current main for Codex usage notice fix
juliusmarminge Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/server/src/provider/CodexProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,7 @@ export const checkCodexProviderStatus = Effect.fn("checkCodexProviderStatus")(fu
? makeUnavailableUsageLimits({
checkedAt,
reason: "probeFailed",
...(accountStatus.message ? { message: accountStatus.message } : {}),
...(snapshot.rateLimits ? { message: snapshot.rateLimits.failure } : {}),
})
: codexRateLimitsToLimits({
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/provider/ProviderRegistry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import { HttpClient, HttpClientResponse } from "effect/http";
import { ChildProcessSpawner } from "effect/process";
import { deepMerge } from "@t3tools/shared/Struct";
import { createModelCapabilities } from "@t3tools/shared/model";
import { limitsNotice } from "@t3tools/shared/usageLimits";
import { applyServerSettingsPatch } from "@t3tools/shared/serverSettings";

import { checkCodexProviderStatus, type CodexAppServerProviderSnapshot } from "./CodexProvider.ts";
Expand Down Expand Up @@ -488,6 +489,11 @@ it.layer(
status.message,
"Codex CLI is not authenticated. Run `codex login` and try again.",
);
assert.isDefined(status.usageLimits);
assert.strictEqual(
limitsNotice(status.usageLimits!),
"Codex CLI is not authenticated. Run `codex login` and try again.",
);
}),
);

Expand Down
Loading