Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions apps/server/src/provider/makeManagedServerProvider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,31 @@ describe("makeManagedServerProvider", () => {
).pipe(Effect.provide(layerAlwaysRunTest)),
);

it.effect("does not enrich a disabled provider's snapshot", () =>
Effect.scoped(
Effect.gen(function* () {
let enrichmentCalls = 0;
const provider = yield* makeManagedServerProvider<TestSettings>({
resolveMaintenance: () => Effect.succeed(maintenanceCapabilities),
getSettings: Effect.succeed({ enabled: false }),
streamSettings: Stream.empty,
haveSettingsChanged: (previous, next) => previous.enabled !== next.enabled,
refreshOnInterval: false,
initialSnapshot: () => Effect.succeed({ ...initialSnapshot, enabled: false }),
checkProvider: Effect.succeed({ ...refreshedSnapshot, enabled: false }),
enrichSnapshot: () => {
enrichmentCalls += 1;
return Effect.void;
},
});

yield* provider.refresh;

assert.strictEqual(enrichmentCalls, 0);
}),
).pipe(Effect.provide(layerAlwaysRunTest)),
);

it.effect("skips periodic provider refreshes without foreground provider-status demand", () =>
Effect.scoped(
Effect.gen(function* () {
Expand Down
4 changes: 3 additions & 1 deletion apps/server/src/provider/makeManagedServerProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ export const makeManagedServerProvider = Effect.fn("makeManagedServerProvider")(
yield* Fiber.interrupt(previousFiber).pipe(Effect.ignore);
}

if (!input.enrichSnapshot) {
// Enrichment resolves binaries and package-manager state, which a disabled
// provider has no use for.
if (!input.enrichSnapshot || !snapshot.enabled) {
return;
}

Expand Down
Loading